Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62445

tool_privacy: export request email comes from user without a name

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.5, 3.4.2, 3.5
    • Fix Version/s: 3.5
    • Component/s: Privacy
    • Labels:
    • Testing Instructions:
      Hide
      1. You need a test site with working emails
      2. Create DPO role and assign to somebody, map DPO role in privacy settings
      3. Login as any user and create an export request
      4. Run cron
      5. Make sure cron has no notices about maildisplay
      6. Check email sent to DPO, make sure it comes from the user (there is a user name in the "from" field)
      Show
      You need a test site with working emails Create DPO role and assign to somebody, map DPO role in privacy settings Login as any user and create an export request Run cron Make sure cron has no notices about maildisplay Check email sent to DPO, make sure it comes from the user (there is a user name in the "from" field)
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-62445-master
    • Pull Master Diff URL:

      Description

      I noticed the error in the cron:

      Notice: Undefined property: stdClass::$maildisplay in /home/marina/repositories/mdk_master/moodle/lib/moodlelib.php on line 6091
      		 
       
      		 
      Notice: Undefined property: stdClass::$maildisplay in /home/marina/repositories/mdk_master/moodle/lib/moodlelib.php on line 6092

      Also the emails to DPO come from user without a name.
      This happens because we pass exported user object to send_message() instead of a db record from 'users' table (or userid)

        Attachments

          Issue Links

          Discovered while testing

          Improvement - An enhancement to an existing Moodle feature. MDL-62134 Add error handling for exports and deletes

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Simey Lameze
              Integrator:
              David Monllaó
              Tester:
              Carlos Escobedo
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18