Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62459

Remove table role_sortorder

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.7
    • 3.6
    • Roles / Access
    • MOODLE_36_STABLE
    • MOODLE_37_STABLE
    • Hide

      1. Verify that there aren't remaining occurrences of role_sortorder in core. Known exceptions are:

      • The fix_role_sortorder() function which name matches the table one, but doesn't use it. So np.
      • The upgrade step, being added here, to get rid of the table. So, obviously, np either.
        Note: You can do it using "git grep role_sortorder"
        You should only see results from lib/accesslib.php and lib/db/upgrade.php.

      2. Once the above has been verified... it's ok to leave this into CiBoT hands for automated testing.

      Show
      1. Verify that there aren't remaining occurrences of role_sortorder in core. Known exceptions are: The fix_role_sortorder() function which name matches the table one, but doesn't use it. So np. The upgrade step, being added here, to get rid of the table. So, obviously, np either. Note: You can do it using " git grep role_sortorder " You should only see results from lib/accesslib.php and lib/db/upgrade.php. 2. Once the above has been verified... it's ok to leave this into CiBoT hands for automated testing .

      It is not used anywhere
      Please address TODO with this issue number in privacy api

      Updated (Eloy):

      I've been looking backwards... and that table was added in 2007, between Moodle 1.8 and 1.9... in this commit and as part of MDL-8965.

      From the issue above it seems clear that the functionality was never implemented, leading to the orphaned table it is. Have searched over the whole history and failed to find any reference to it. I think it comes from old days where stuff was sent by any dev to CVS unfinished... and that caused it to become lost in the middle.

      So, yes, time to remove it completely. +1

        1. image-2019-04-23-11-09-06-076.png
          image-2019-04-23-11-09-06-076.png
          27 kB

            stronk7 Eloy Lafuente (stronk7)
            marina Marina Glancy
            David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
            Jun Pataleta Jun Pataleta
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 50 minutes
                1h 50m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.