Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62459

Remove table role_sortorder

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.7
    • Component/s: Roles / Access
    • Labels:
    • Testing Instructions:
      Hide

      1. Verify that there aren't remaining occurrences of role_sortorder in core. Known exceptions are:

      • The fix_role_sortorder() function which name matches the table one, but doesn't use it. So np.
      • The upgrade step, being added here, to get rid of the table. So, obviously, np either.
        Note: You can do it using "git grep role_sortorder"
        You should only see results from lib/accesslib.php and lib/db/upgrade.php.

      2. Once the above has been verified... it's ok to leave this into CiBoT hands for automated testing.

      Show
      1. Verify that there aren't remaining occurrences of role_sortorder in core. Known exceptions are: The fix_role_sortorder() function which name matches the table one, but doesn't use it. So np. The upgrade step, being added here, to get rid of the table. So, obviously, np either. Note: You can do it using " git grep role_sortorder " You should only see results from lib/accesslib.php and lib/db/upgrade.php. 2. Once the above has been verified... it's ok to leave this into CiBoT hands for automated testing .
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      It is not used anywhere
      Please address TODO with this issue number in privacy api

      Updated (Eloy):

      I've been looking backwards... and that table was added in 2007, between Moodle 1.8 and 1.9... in this commit and as part of MDL-8965.

      From the issue above it seems clear that the functionality was never implemented, leading to the orphaned table it is. Have searched over the whole history and failed to find any reference to it. I think it comes from old days where stuff was sent by any dev to CVS unfinished... and that caused it to become lost in the middle.

      So, yes, time to remove it completely. +1

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 50 minutes
                  1h 50m