Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62468

Participants page initialises core_user/participants JS in a way that triggers the "Too many params passed to js_call_amd" debug

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 3.4.2, 3.9, 4.0.6, 4.1.1, 4.2
    • User management
    • MOODLE_34_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE
    • Hide
      1. Log as admin
      2. Set the debugging level to developer debugging and let debugging messages display
      3. Make sure that Site administration > Advanced features > Enable notes is checked
      4. Install French package
      5. Go to a course with enrolled participants
      6. Go to the participants page
      7. Switch to the French language
      8. TEST Check that you do not see the "Too many params passed to js_call_amd(...)" warning below the list of participants.
      9. You ccan switch back to your default language if you prefer now
      10. Select some participants
      11. Below the list, choose "With selected users ..." > Add a new note
      12. TEST In the popup, check that hovering the help icon shows title "Help with Context" and clicking the icon shows well formatted help text.
      Show
      Log as admin Set the debugging level to developer debugging and let debugging messages display Make sure that Site administration > Advanced features > Enable notes is checked Install French package Go to a course with enrolled participants Go to the participants page Switch to the French language TEST Check that you do not see the "Too many params passed to js_call_amd(...)" warning below the list of participants. You ccan switch back to your default language if you prefer now Select some participants Below the list, choose "With selected users ..." > Add a new note TEST In the popup, check that hovering the help icon shows title "Help with Context" and clicking the icon shows well formatted help text.

      As discovered by stronk7 in MDL-62354, when the string publishstate_help exceeds certain length, a debugging warning is raised:

      Too many params passed to js_call_amd("core_user/participants", "init")
      		 
              line 1025 of /lib/outputrequirementslib.php: call to debugging()
      		 
              line 337 of /user/index.php: call to page_requirements_manager->js_call_amd()

      String length should not affect these things, an alternative way for passing data for the module shall be researched.

        1. 0001-MDL-62468-output-Improve-the-debug-message-on-js_cal.patch
          2 kB
        2. image-2020-02-05-13-50-29-575.png
          image-2020-02-05-13-50-29-575.png
          57 kB
        3. screenshot-1.png
          screenshot-1.png
          57 kB
        4. screenshot-2.png
          screenshot-2.png
          54 kB

            Unassigned Unassigned
            mudrd8mz David Mudrák (@mudrd8mz)
            David Mudrák (@mudrd8mz) David Mudrák (@mudrd8mz)
            Votes:
            20 Vote for this issue
            Watchers:
            23 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 55 minutes
                1h 55m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.