Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62478

Add Moodle 3.5.0 upgrade line to all the upgrade.php scripts

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.5.1
    • 3.5, 3.6
    • Installation
    • MOODLE_35_STABLE, MOODLE_36_STABLE
    • MOODLE_35_STABLE
    • Hide

      1) Check that all the "Command(s) to detect ..." in the description of the issue work as expected (no occurrences normally, some cases or exceptions allowed in some of them...)

      2) Check all upgrade scripts have the 3.5.0 comment before the return with:

       find . -name upgrade.php | xargs grep -B4 'return true;'

      • Usual exception : ./question/upgrade.php, ignore it. It's not a upgrade script.
      • This time exception : ./mod/glossary/db/upgrade.php already has got a upgrade step (2018051401). The upgrade line should be BEFORE it.
      • Random exceptions: Some upgrade scripts could be missing the comments before the return. Surely it's because some new steps already have been introduced after release. Verify the comments are present in the correct place (before those new steps).

      3) This should return nothing too or the same exceptions as in step 2:

      for u in `find . -name upgrade.php | grep 'db/upgrade'`; do grep -B4 'return true;' "$u" | grep "Automatically generated" > /dev/null; if [ $? -ne 0 ]; then echo "$u"; fi ; done

      4) Verify that the differences between the stable branch and master continue being 100% the same after the patch than before it (aka. the patch is 100% the same for both branches).

      5) rock on.

      Show
      1) Check that all the " Command(s) to detect ..." in the description of the issue work as expected (no occurrences normally, some cases or exceptions allowed in some of them...) 2) Check all upgrade scripts have the 3.5.0 comment before the return with: find . -name upgrade.php | xargs grep -B4 'return true;' Usual exception : ./question/upgrade.php, ignore it. It's not a upgrade script. This time exception : ./mod/glossary/db/upgrade.php already has got a upgrade step (2018051401). The upgrade line should be BEFORE it. Random exceptions: Some upgrade scripts could be missing the comments before the return. Surely it's because some new steps already have been introduced after release. Verify the comments are present in the correct place (before those new steps). 3) This should return nothing too or the same exceptions as in step 2: for u in `find . -name upgrade.php | grep 'db/upgrade'`; do grep -B4 'return true;' "$u" | grep "Automatically generated" > /dev/null; if [ $? -ne 0 ]; then echo "$u"; fi ; done 4) Verify that the differences between the stable branch and master continue being 100% the same after the patch than before it (aka. the patch is 100% the same for both branches). 5) rock on.

      (NOTE: Before 3.2, the comment was "// Moodle v3.1.0 release upgrade line." and it was changed to have "Automatically generated..." for v3.2.0 and upwards.)

      In order to have it properly detected for the future it would be great to add to all the upgrade.php scripts some lines like these:

      // Automatically generated Moodle v3.5.0 release upgrade line.
      		 
      // Put any upgrade step following this.

      exactly before the "return true;" present in all the scripts.

      I think it's ok to do that both in the 35_STABLE and master branches, so they will allow quickly find where 3.5.0 started and act once we decide future requirements.

      The change can be performed globally with:

      #!/bin/bash
      		 
      export rel="3.5.0" && find . -name upgrade.php | \
      		 
      xargs grep -l 'function.*xmldb_.*_upgrade' | \
      		 
      grep '/db/' | \
      		 
      xargs grep -L "Automatically generated Moodle v${rel} release upgrade" | \
      		 
      xargs perl -p -i -e 's@( *)(return true;)@\1// Automatically generated Moodle v$ENV{rel} release upgrade line.\n\1// Put any upgrade step following this.\n\n\1\2@s'

      Command to detect all the upgrade.php files not having those lines:

      find . -name upgrade.php | xargs grep -l 'function.*xmldb_.*_upgrade' | grep '/db/' | xargs grep -L 'Automatically generated Moodle v3.5.0 release upgrade'

      Commands to detect that we have not added the lines to incorrect files:

      grep -lr 'Automatically generated Moodle v3.5.0 release upgrade' * | grep -v '/db/'
      		 
      grep -lr 'Automatically generated Moodle v3.5.0 release upgrade' * | xargs grep -L 'function.*xmldb_.*_upgrade'

      Command to detect if the lines have been added after a post-release upgrade step. If there are upgrade steps found verify that all them were already there the day of the release and have not been introduced later (you can look for differences between the release v3.5.0 and current master to verify that)

      export rel="3.5.0" && export ver="201805" &&
      		 
      find . -name upgrade.php | \
      		 
      xargs grep -B25 "Automatically generated Moodle v${rel} release upgrade" | \
      		 
      grep "upgrade_.*_savepoint.*${ver}"

      Ciao

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Andrew Lyons Andrew Lyons
            David Monllaó David Monllaó
            Mihail Geshoski Mihail Geshoski
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.