Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62528

Forum post accessed via permalinks are shown right underneath the nav bar in Boost

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.3, 3.5.1, 3.6
    • Fix Version/s: 3.4.6, 3.5.3
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide

      Summary

      We need to test that clicking Permalinks on forum posts/replies loads the post at the top of the page, but low enough that part of the post is not cut off at the top of the page. This needs to be confirmed for the Moodle supported browsers.

      Setup

      1. Open Chrome as your browser.
      2. Log into your test Moodle site as admin.
      3. Purge all Moodle site caches ( {yoursite}/admin/purgecaches.php).

      Testing
      Note: Test required in Boost only.

      1. Create a forum 'f1' within a course on your test site.
      2. Open forum f1, and add a new discussion topic 'dt1'.
      3. Open the discussion topic dt1, and generate a reply to the original post, as well as a reply to your reply (so there are multiple different reply levels).
      4. Return to discussion topic dt1, so you can see all of the posts and replies.
      5. Click each of the Permalink links at the bottom of each post
        1. CONFIRM the relevant post is moved to the top of the page
        2. CONFIRM the top of the post is visible, and is not cut off at the top of the page.
      6. Navigate back to your course page.
      7. Click on the gear icon top right and click Edit settings.
      8. Click the collapsed Course format section and check if the Course layout is set to "Show all sections on one page"
      9. Navigate back to your course page.
      10. Check you have at least 4 sections on your course page.
      11. In each section add a label with at least 15 lines of text using dummy text from http://www.blindtextgenerator.com/lorem-ipsum.
      12. On the course page click on the section links in your navdrawer.
      13. Click each of the Section links in the site navdrawer
        1. CONFIRM the relevant section is moved to the top of the page
        2.  CONFIRM the top of the section is visible, and is not cut off at the top of the page.
      14. Open Firefox.
      15. Log into your test site as admin.
      16. Repeat step 5 and 13.

      If possible, it might be worth testing in any other browsers if they are available.

      Show
      Summary We need to test that clicking Permalinks on forum posts/replies loads the post at the top of the page, but low enough that part of the post is not cut off at the top of the page. This needs to be confirmed for the Moodle supported browsers. Setup Open Chrome as your browser. Log into your test Moodle site as admin. Purge all Moodle site caches ( {yoursite}/admin/purgecaches.php). Testing Note: Test required in Boost only. Create a forum 'f1' within a course on your test site. Open forum f1, and add a new discussion topic 'dt1'. Open the discussion topic dt1, and generate a reply to the original post, as well as a reply to your reply (so there are multiple different reply levels). Return to discussion topic dt1, so you can see all of the posts and replies. Click each of the Permalink links at the bottom of each post CONFIRM the relevant post is moved to the top of the page CONFIRM the top of the post is visible, and is not cut off at the top of the page. Navigate back to your course page. Click on the gear icon top right and click Edit settings. Click the collapsed Course format section and check if the Course layout is set to "Show all sections on one page" Navigate back to your course page. Check you have at least 4 sections on your course page. In each section add a label with at least 15 lines of text using dummy text from  http://www.blindtextgenerator.com/lorem-ipsum . On the course page click on the section links in your navdrawer. Click each of the Section links in the site navdrawer CONFIRM  the relevant section is moved to the top of the page   CONFIRM  the top of the section is visible, and is not cut off at the top of the page. Open Firefox. Log into your test site as admin. Repeat step 5 and 13. If possible, it might be worth testing in any other browsers if they are available.
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-62528-master

      Description

      To reproduce:

      1. Open your test site in Chrome browser.
      2. Set the theme on Boost.
      3. Create a forum.
      4. Add a discussion and create one or more posts in that discussion.
      5. Click on the permalink of any post.
        • Expected: The page scrolls to the post and shows the whole post.
        • Actual: The page scrolls to the post but goes right underneath the nav bar.

      Seems it only affects Boost.

      This works perfectly in Clean.

        Attachments

        1. boost.png
          boost.png
          35 kB
        2. clean.png
          clean.png
          48 kB
        3. image-2018-09-12-09-50-57-295.png
          image-2018-09-12-09-50-57-295.png
          78 kB
        4. screenshot-1.png
          screenshot-1.png
          38 kB
        5. without-target.png
          without-target.png
          27 kB
        6. with-target.png
          with-target.png
          28 kB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/18