Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62535

Rubrics do not consider the fillings table

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3.6, 3.4.3, 3.5.1
    • Fix Version/s: 3.6
    • Component/s: Grading methods, Privacy
    • Labels:
    • Testing Instructions:
      Hide

      Important This test requires changing code.

      Test export of advanced grading information.

      Rubrics

      1. Setup a rubric in an assignment activity.
        1. Create a new assignment.
        2. Under "Grade" > "Grading method" set this to Rubric.
        3. Click the Define new grading form from scratch.
        4. Add some criteria and then click the "save rubric and make it ready".
      2. Log in as a teacher and mark a student. Add feedback to each criterion.
      3. Use the script and export the data for the marked student.
      4. Verify that the rubric data is exported. This is located under the submission attempt in the assignment folder.

      Marking guide

      1. Setup a marking guide in an assignment activity.
        1. Create a new assignment.
        2. Under "Grade" > "Grading method" set this to Marking guide.
        3. Click the Define new grading form from scratch.
        4. Add some criteria and then click the "save marking guide and make it ready".
      2. Log in as a teacher and mark a student. Add feedback to each criterion.
      3. Use the script and export the data for the marked student.
      4. Verify that the marking guide data is exported. This is located under the submission attempt in the assignment folder.

      Test deprecated plugin display in the plugin privacy registry.

      1. Download 0001-MDL-62535-privacy-Deprecated-sample-commit.patch
      2. Open a terminal and go to your Moodle instance's root folder.
      3. Apply the test patch to your moodle instance:

        git am /path/to/0001-MDL-62535-privacy-Deprecated-sample-commit.patch
        

      4. On your browser, go to Site administration > Users > Privacy and policies > Plugin privacy registry.
      5. Confirm that there is a description about deprecated plugins in the top section.
      6. Confirm that expanding the "Advanced grading method" section shows Rubric to be deprecated.
      After the test
      1. Make sure to remove the test patch using "git reset --hard origin/YOUR_MOODLE_BRANCH".
        e.g. for master

        git reset --hard origin/master
        

      Show
      Important This test requires changing code. Test export of advanced grading information. Rubrics Setup a rubric in an assignment activity. Create a new assignment. Under "Grade" > "Grading method" set this to Rubric. Click the Define new grading form from scratch. Add some criteria and then click the "save rubric and make it ready". Log in as a teacher and mark a student. Add feedback to each criterion. Use the script and export the data for the marked student. Verify that the rubric data is exported. This is located under the submission attempt in the assignment folder. Marking guide Setup a marking guide in an assignment activity. Create a new assignment. Under "Grade" > "Grading method" set this to Marking guide. Click the Define new grading form from scratch. Add some criteria and then click the "save marking guide and make it ready". Log in as a teacher and mark a student. Add feedback to each criterion. Use the script and export the data for the marked student. Verify that the marking guide data is exported. This is located under the submission attempt in the assignment folder. Test deprecated plugin display in the plugin privacy registry. Download 0001-MDL-62535-privacy-Deprecated-sample-commit.patch Open a terminal and go to your Moodle instance's root folder. Apply the test patch to your moodle instance: git am /path/to/0001-MDL-62535-privacy-Deprecated-sample-commit.patch On your browser, go to Site administration > Users > Privacy and policies > Plugin privacy registry. Confirm that there is a description about deprecated plugins in the top section. Confirm that expanding the "Advanced grading method" section shows Rubric to be deprecated. After the test Make sure to remove the test patch using " git reset --hard origin/YOUR_MOODLE_BRANCH ". e.g. for master git reset --hard origin/master
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Epic Link:
    • Pull from Repository:
    • Pull Master Branch:
      MDL-62535-master
    • Sprint:
      GDPR Followup Sprint 1

      Description

      As pointed out by Marcus Green, gradingform_rubric does not consider its gradingform_rubric_fillings table as having any personal data.

      Although the table has no userid, it has an itemid which relates to the gradeitem id, which is linked to a user.
      The fillings table includes details of the level and any remarks.

      https://moodle.org/mod/forum/discuss.php?d=370983#p1495800

      It may be that we can do something generic which covers all grading methods. Although I can see a get_rubric_filling() function, the only accessible description of this comes from get_external_instance_filling_details, which is aimed at web services.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/18