Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62543

New 'deleted' field for forum posts is used in the wrong way for rss feeds

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Go to admin/settings.php?section=optionalsubsystems
      2. Tick enablerssfeeds
      3. Go to admin/settings.php?section=modsettingforum
      4. Set forum_enablerssfeeds to Yes
      5. Create a forum with discussions and posts, e.g. through

        php admin/tool/generator/cli/maketestcourse.php --shortname=SIZE_S3 --size=S

      1. Go to the settings of the forum and set
        1. RSS feed for this activity to Posts
        2. Number of RSS recent articles to 5
      2. Click on RSS feed of posts in the Forum Administration
      3. Expected behaviour is that there are >0 entries
      4. Go to the settings of the forum and set
        1. RSS feed for this activity to Discussions
        2. Number of RSS recent articles to 5
      5. Click on RSS feed of discussions in the Forum Administration
      6. Expected behaviour is that there are >0 entries
      Show
      Go to admin/settings.php?section=optionalsubsystems Tick enablerssfeeds Go to admin/settings.php?section=modsettingforum Set forum_enablerssfeeds to Yes Create a forum with discussions and posts, e.g. through php admin/tool/generator/cli/maketestcourse.php --shortname=SIZE_S3 --size=S Go to the settings of the forum and set RSS feed for this activity to Posts Number of RSS recent articles to 5 Click on RSS feed of posts in the Forum Administration Expected behaviour is that there are >0 entries Go to the settings of the forum and set RSS feed for this activity to Discussions Number of RSS recent articles to 5 Click on RSS feed of discussions in the Forum Administration Expected behaviour is that there are >0 entries
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-62543-master
    • Sprint:
      Privacy Sprint 1

      Description

      Since 3.4.3 all our rss feeds are empty. With the implementation of the Privacy API the 'deleted' field was added to forum posts. In the rsslib.php this was added to two sql queries, which determine the posts, which should be displayed in the feed. However, both queries check for <> 0 instead of <> 1 and thus do not exclude all deleted queries, but all non deleted queries instead. In the lib.php, where this deleted flag is also used for filtering posts, it is correctly used with <> 1.

      This is a regression from MDL-61309.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              tobias.reischmann Tobias Reischmann
              Reporter:
              tobias.reischmann Tobias Reischmann
              Peer reviewer:
              Víctor Déniz Falcón
              Integrator:
              Andrew Nicols
              Tester:
              Gladys Basiana
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              3 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/18

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h