[MDL-62543] New 'deleted' field for forum posts is used in the wrong way for rss feeds - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.4.3, 3.5, 3.5 regressions
Fix Version/s: 3.3.7, 3.4.4, 3.5.1
Component/s: Forum
Labels:
- ci
- moodle.org
- patch
- release_notes

Affected Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Fixed Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
Epic Link:
GDPR Followups
Pull from Repository:
git://github.com/tobiasreischmann/moodle.git
Pull Master Branch:
~~MDL-62543~~-master
Pull Master Diff URL:
https://github.com/tobiasreischmann/moodle/compare/22744b745b...MDL-62543-master
Testing Instructions:
Hide

Go to admin/settings.php?section=optionalsubsystems

Tick enablerssfeeds

Go to admin/settings.php?section=modsettingforum

Set forum_enablerssfeeds to Yes

Create a forum with discussions and posts, e.g. through

php admin/tool/generator/cli/maketestcourse.php --shortname=SIZE_S3 --size=S

Go to the settings of the forum and set

RSS feed for this activity to Posts

Number of RSS recent articles to 5

Click on RSS feed of posts in the Forum Administration

Expected behaviour is that there are >0 entries

Go to the settings of the forum and set

RSS feed for this activity to Discussions

Number of RSS recent articles to 5

Click on RSS feed of discussions in the Forum Administration

Expected behaviour is that there are >0 entries
Show
Go to admin/settings.php?section=optionalsubsystems Tick enablerssfeeds Go to admin/settings.php?section=modsettingforum Set forum_enablerssfeeds to Yes Create a forum with discussions and posts, e.g. through php admin/tool/generator/cli/maketestcourse.php --shortname=SIZE_S3 --size=S Go to the settings of the forum and set RSS feed for this activity to Posts Number of RSS recent articles to 5 Click on RSS feed of posts in the Forum Administration Expected behaviour is that there are >0 entries Go to the settings of the forum and set RSS feed for this activity to Discussions Number of RSS recent articles to 5 Click on RSS feed of discussions in the Forum Administration Expected behaviour is that there are >0 entries

Sprint:
Privacy Sprint 1

Description

Since 3.4.3 all our rss feeds are empty. With the implementation of the Privacy API the 'deleted' field was added to forum posts. In the rsslib.php this was added to two sql queries, which determine the posts, which should be displayed in the feed. However, both queries check for <> 0 instead of <> 1 and thus do not exclude all deleted queries, but all non deleted queries instead. In the lib.php, where this deleted flag is also used for filtering posts, it is correctly used with <> 1.

This is a regression from ~~MDL-61309~~.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Verified_MDL_62543.PNG
42 kB
30/May/18 5:46 PM

Issue Links

has a non-specific relationship to

MDLSITE-5467 RSS content is missing

Resolved

is a regression caused by

MDL-61309 Implement 'request' interface for mod_forum

Closed

is duplicated by

MDL-62595 Forum RSS feeds broken

Closed

Activity

People

Assignee:: Tobias Reischmann

Reporter:: Tobias Reischmann

Peer reviewer:: Victor Déniz Falcón

Integrator:: Andrew Lyons

Tester:: Gladys Basiana

Participants:: Andrew Lyons, CiBoT, David Monllaó, Gladys Basiana, Tobias Reischmann, Victor Déniz Falcón

Component watchers:: Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie

Votes:: 3 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 24/May/18 4:00 AM

Updated:: 13/Sep/18 7:04 AM

Resolved:: 01/Jun/18 2:51 AM

Fix Release Date:: 9/Jul/18

Time Tracking

Estimated:

Not Specified

Remaining:

Logged: