Improve bulk deletion

Test in Boost and Clean.

Pre-requisites

1. Create multiple users.

Test 1.

1. Login as Admin.
2. Go to 'Site administration' > 'Privacy and policies' > 'Privacy settings'.
   • make sure a setting 'Create automatic data deletion requests' exists.
   • make sure the default value of this setting:
     • master:  setting is enabled by default.
     • 35, 34, 33:  setting is disabled by default.
3. Enable the setting 'Create automatic data deletion requests' (if not already enabled).
4. Go to 'Site administration' > 'Users' > 'Bulk user actions'.
5. Select several users from the list.
6. From the 'With selected users...' select 'Delete'.
7. Confirm the deletion.
8. Go to 'Site administration' > 'Users' > 'Privacy and policies' > 'Data requests'.
   • make sure delete data requests are created for the deleted users.
   • make sure the requests contain the message "Automatically created upon user deletion."
   • make sure you can properly filter the results by the creation method ('Creation: Manually/Automatically')
9. Run the cron. ('php admin/cli/cron.php')
10. Approve the requests and run the cron once again.
    • make sure everything works as expected.

Test 2.

1. Login as Admin.
2. Go to 'Site administration' > 'Privacy and policies' > 'Privacy settings'.
   • make sure a setting 'Create automatic data deletion requests' exists.
   • make sure the default value of this setting:
     • master:  setting is enabled by default.
     • 35, 34, 33:  setting is disabled by default.
3. Disable the setting 'Create automatic data deletion requests' (if not already disabled).
4. Go to 'Site administration' > 'Users' > 'Bulk user actions'.
5. Select several users from the list.
6. From the 'With selected users...' select 'Delete'.
7. Confirm the deletion.
8. Go to 'Site administration' > 'Users' > 'Privacy and policies' > 'Data requests'.
   • make sure delete data requests are NOT being created for the deleted users.

Test 3. 

1. Login as Admin.
2. Go to 'Site administration' > 'Privacy and policies' > 'Privacy settings'.
   • make sure a setting 'Create automatic data deletion requests' exists.
   • make sure the default value of this setting:
     • master:  setting is enabled by default.
     • 35, 34, 33:  setting is disabled by default.
3. Disable the setting 'Create automatic data deletion requests' (if not already disabled).
4. Go to 'Site administration' > 'Users' > 'Bulk user actions'.
5. Select several users from the list.
6. From the 'With selected users...' select 'Delete'.
7. Confirm the deletion.
8. Go to 'Site administration' > 'Users' > 'Privacy and policies' > 'Data requests'.
   • make sure delete data requests are NOT being created for the deleted users.
9. Run the scheduled task to create delete data requests for pre-existing deleted users ('php admin/tool/task/cli/schedule_task.php --execute='tool_dataprivacy\task\delete_existing_deleted_users').
10. Go to Site administration > Users > Privacy and policies > Data requests.
11. Make sure data delete data requests have NOT been created for the deleted users. 
12. Go to 'Site administration' > 'Privacy and policies' > 'Privacy settings'.
13. Enable the setting 'Create automatic data deletion requests'.
14. Run the scheduled task to create delete data requests for pre-existing deleted users ('php admin/tool/task/cli/schedule_task.php --execute='tool_dataprivacy\task\delete_existing_deleted_users').
15. Go to Site administration > Users > Privacy and policies > Data requests.
16. Make sure data delete data requests have been created for the deleted users. 
17. Additionally make sure that further actions such as viewing, approving and denying these particular requests works as expected. 

Process the deletions

1. Ensure you have some approved deletion requests
2. Run cron