[MDL-62576] Course jump to menu not centred in Bootstrap V4 Stable - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5, 3.6
Fix Version/s: 3.5.1
Component/s: Course, Themes
Labels:
- ci

Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_35_STABLE
Pull from Repository:
git://github.com/gjb2048/moodle.git
Pull Master Branch:
wip_~~MDL-62576~~_master
Pull Master Diff URL:
https://github.com/gjb2048/moodle/compare/master...wip_MDL-62576_master
Workaround:

Hide

Add the following custom CSS to the theme:

.format-topics .jumpmenu .form-inline,

.format-weeks .jumpmenu .form-inline {

display: block;
}

Show
Add the following custom CSS to the theme: .format-topics .jumpmenu .form-inline, .format-weeks .jumpmenu .form-inline { display: block; }
Testing Instructions:
Hide

Select the Boost theme.

Create a new course:

set the course format to "Topics"

set the default number of topics to 3

set the course layout setting to 'One section per page'.

Navigate to the course

Select the title of second topic shown

Confirm that the 'Jump to...' navigation menu at the bottom of the topic between the Topic 1 and Topic 3 navigation links is centred

Edit the course settings

Change the course format to Weekly

Select the title of second week shown

Confirm that the 'Jump to...' navigation menu at the bottom of the topic between the previous and next weeks navigation links is centred
Show
Select the Boost theme. Create a new course: set the course format to "Topics" set the default number of topics to 3 set the course layout setting to 'One section per page'. Navigate to the course Select the title of second topic shown Confirm that the 'Jump to...' navigation menu at the bottom of the topic between the Topic 1 and Topic 3 navigation links is centred Edit the course settings Change the course format to Weekly Select the title of second week shown Confirm that the 'Jump to...' navigation menu at the bottom of the topic between the previous and next weeks navigation links is centred

Description

With the upgrade to Bootstrap version 4 stable in ~~MDL-56511~~ the form markup was changed to the flexbox model. This causes the 'Jump to' menu on single page courses to no longer be centred.

As seen here:

Only affects Bootstrap version 4 based themes.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-62576.PNG
25 kB
13/Jun/18 6:27 PM
Screenshot_2018-05-23 Course Topics single section, Topic Topic 2.png
42 kB
26/May/18 3:40 AM
Screen Shot 2018-05-29 at 10.39.14.png
104 kB
30/May/18 12:39 AM

Issue Links

is a regression caused by

MDL-56511 Update bootstrap 4 to final release

Closed

Testing discovered

MDL-62642 Improve renderer for section navigation in one section per page layout

Closed

Activity

People

Assignee:: Gareth J Barnard

Reporter:: Gareth J Barnard

Peer reviewer:: Bas Brands

Integrator:: Andrew Lyons

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, Bas Brands, CiBoT, Eloy Lafuente (stronk7), Gareth J Barnard

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona), Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 26/May/18 3:38 AM

Updated:: 15/Jun/18 3:51 AM

Resolved:: 15/Jun/18 3:51 AM

Fix Release Date:: 9/Jul/18

Time Tracking

Estimated:

Remaining:

Logged:

30m