Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62605

Unenrol confirmation modal does not apply filter for course fullname

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login as an admin.
      2. Go to "Site administration / Language / Language packs / Install another language pack".
      3. Install any language pack you prefer and take note the value enclosed in parentheses beside that language pack's name.
      4. Go to "Site administration / Plugins / Filters / Manage filters"
      5. Activate the "Multi-Language Content" filter and apply it to "Content and headings"
      6. Create a course with a multi-language name. e.g. If you installed the Japanese (ja) language pack:

        Test course 1 <span lang="en" class="multilang">EN</span><span lang="ja" class="multilang">JA</span>

      7. Enrol a student in that course.
      8. Go to the "Participants" page.
      9. Try to unenrol the student from the course by clicking the trash bin icon.
      10. Confirm that the course's name in the modal shows the course name in the correct language. e.g. if it's in English, the course name should be displayed as "Test course 1 EN". If it's in Japanese, it should be displayed as "Test course 1 JA".
      11. Close the unenrol modal.
      12. Click on the details icon ("i") of any participant under the "Status" field.
      13. Confirm that the course's name in the modal shows the course name in the correct language. e.g. if it's in English, the course name should be displayed as "Test course 1 EN". If it's in Japanese, it should be displayed as "Test course 1 JA".
      Show
      Login as an admin. Go to " Site administration / Language / Language packs / Install another language pack ". Install any language pack you prefer and take note the value enclosed in parentheses beside that language pack's name. Go to " Site administration / Plugins / Filters / Manage filters " Activate the " Multi-Language Content " filter and apply it to " Content and headings " Create a course with a multi-language name. e.g. If you installed the Japanese (ja) language pack: Test course 1 <span lang="en" class="multilang">EN</span><span lang="ja" class="multilang">JA</span> Enrol a student in that course. Go to the " Participants " page. Try to unenrol the student from the course by clicking the trash bin icon. Confirm that the course's name in the modal shows the course name in the correct language. e.g. if it's in English, the course name should be displayed as " Test course 1 EN ". If it's in Japanese, it should be displayed as " Test course 1 JA ". Close the unenrol modal. Click on the details icon (" i ") of any participant under the " Status " field. Confirm that the course's name in the modal shows the course name in the correct language. e.g. if it's in English, the course name should be displayed as " Test course 1 EN ". If it's in Japanese, it should be displayed as " Test course 1 JA ".
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-62605-master

      Description

      The unenrol modal states a question in which the course fullname has not passed filters.

      To reproduce:

      • Have two languages (e.g. ru and en) installed.
      • Have multilang filter active.
      • Create a course, call it <span lang="en" class="multilang">Course</span><span lang="ru" class="multilang">курс</span>.
      • Have a student manually enrolled in that course.
      • Go to the participants page.
      • Try to unenrol the student from the course by clicking the trash bin icon.
      • A modal pops up, asking for confirmation.

      WHAT YOU EXPECT:
      It says "Do you really want to unenrol "Sam Student" (previously enrolled via "Manual enrolments") from "Course"?", respecting the multilang filter.

      WHAT ACTUALLY HAPPENS:
      It says "Do you really want to unenrol "Sam Student" (previously enrolled via "Manual enrolments") from "Courseкурс"?, not respecting the multilang filter.

        Attachments

        1. MDL-62605.png
          MDL-62605.png
          56 kB
        2. Step10_MDL-62605.PNG
          Step10_MDL-62605.PNG
          10 kB
        3. Step13_MDL-62605.PNG
          Step13_MDL-62605.PNG
          18 kB

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m