Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62618

GDPR Issue: User policies Error

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test setup:

      1. Log into test Moodle site as an admin user.
      2. Add two test student users (referred to below as s1 and s2) if one does not already exist, noting down their first and last names to refer to later.
      3. Add a new course (course1).
      4. Add a forum activity to course1 with forum name forum1, forum type "Standard forum for general use".
      5. In Site administration, navigate to Users > Category: Permissions.
      6. Set 'Full name format' (fullnamedisplay) to 'lastname'.
      7. Set 'Alternative full name format' (alternativefullnameformat) to 'firstname lastname'.
      8. Click the 'Save changes' button.

      Test users (participants/enrolment):

      1. Open course1 and click Participants.
      2. Click the Enrol users button.
      3. Ensure the assign role option is set to 'Student' (this should already be the default).
      4. Start typing s1's name into the search input.
      5. CONFIRM s1's name appears in the format 'firstname lastname' in the suggestions.
      6. Click s1's name in suggestions and CONFIRM the student's name appears next to "Select users" in the format 'firstname lastname'.
      7. Repeat for s2, so that you will be enrolling two students into the course.
      8. Click Enrol users. You will be returned to the Participants list.
      9. CONFIRM the row containing s1's name shows their name in the format 'firstname lastname', and CONFIRM the heading of that column appears as "First name /Surname".
      10. Mouseover s1's avatar (image/icon to the left of their name). CONFIRM the mouseover text is in the format "Picture of firstname lastname".
      11. On the far right of s1's row, click each of the three icons (the information 'i', settings cog and delete bin), and in each, CONFIRM s1's name appears in the format 'firstname lastname' wherever it appears in each of those modal popups.
      12. Log out of the site, and log back in as the second test student (s2).
      13. Open course1 and click Participants.
      14. CONFIRM s1's name appears in te participants list as their surname only.
      15. CONFIRM the heading of the column containing names is 'Surname'.
      16. Mouseover s1's avatar. CONFIRM the mouseover text is in the format 'Picture of lastname'.

      Test forum:

      1. While still logged in as s2, navigate to course1, and open the test forum (forum1).
      2. Click 'Add a new discussion topic'.
      3. Add 'test topic' into Subject and Message and click 'Post to forum'. You will be redrected back to the forum view.
      4. CONFIRM under both the 'Started by' and 'Last post' headings on the test topic discussion row, you see s1's surname only.
      5. Under the Started by heading, confirm when you mouseover s1's avatar, you see mouseover text in the format 'Picture of lastname'.
      6. Log out, and log back in as an admin user.
      7. Reopen forum1 in course1.
      8. CONFIRM under both the 'Started by' and 'Last post' headings on the test topic discussion row, you see s1's name in the format 'firstname lastname'.
      9. CONFIRM the mouseover text for s1's avatar is in the format 'Picture of firstname lastname'.
      Show
      Test setup: Log into test Moodle site as an admin user. Add two test student users (referred to below as s1 and s2) if one does not already exist, noting down their first and last names to refer to later. Add a new course (course1). Add a forum activity to course1 with forum name forum1, forum type "Standard forum for general use". In Site administration, navigate to Users > Category: Permissions. Set 'Full name format' (fullnamedisplay) to 'lastname'. Set 'Alternative full name format' (alternativefullnameformat) to 'firstname lastname'. Click the 'Save changes' button. Test users (participants/enrolment): Open course1 and click Participants. Click the Enrol users button. Ensure the assign role option is set to 'Student' (this should already be the default). Start typing s1's name into the search input. CONFIRM s1's name appears in the format 'firstname lastname' in the suggestions. Click s1's name in suggestions and CONFIRM the student's name appears next to "Select users" in the format 'firstname lastname'. Repeat for s2, so that you will be enrolling two students into the course. Click Enrol users. You will be returned to the Participants list. CONFIRM the row containing s1's name shows their name in the format 'firstname lastname', and CONFIRM the heading of that column appears as "First name /Surname". Mouseover s1's avatar (image/icon to the left of their name). CONFIRM the mouseover text is in the format "Picture of firstname lastname". On the far right of s1's row, click each of the three icons (the information 'i', settings cog and delete bin), and in each, CONFIRM s1's name appears in the format 'firstname lastname' wherever it appears in each of those modal popups. Log out of the site, and log back in as the second test student (s2). Open course1 and click Participants. CONFIRM s1's name appears in te participants list as their surname only. CONFIRM the heading of the column containing names is 'Surname'. Mouseover s1's avatar. CONFIRM the mouseover text is in the format 'Picture of lastname'. Test forum: While still logged in as s2, navigate to course1, and open the test forum (forum1). Click 'Add a new discussion topic'. Add 'test topic' into Subject and Message and click 'Post to forum'. You will be redrected back to the forum view. CONFIRM under both the 'Started by' and 'Last post' headings on the test topic discussion row, you see s1's surname only. Under the Started by heading, confirm when you mouseover s1's avatar, you see mouseover text in the format 'Picture of lastname'. Log out, and log back in as an admin user. Reopen forum1 in course1. CONFIRM under both the 'Started by' and 'Last post' headings on the test topic discussion row, you see s1's name in the format 'firstname lastname'. CONFIRM the mouseover text for s1's avatar is in the format 'Picture of firstname lastname'.
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull 3.4 Branch:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-62618-master

      Description

      This error has been handled before in issue: MDL-55915 but it hasnt solved the whole problem.

      In forums and other views where names are present we sometimes get very mixed firstname / lastname combinations.

      We have these settings: [ https://www.screencast.com/t/yj7wgyESihi|https://www.screencast.com/t/yj7wgyESihi]

      It shows both firstname and lastname: [ https://www.screencast.com/t/Zr3zdA1bD|https://www.screencast.com/t/Zr3zdA1bD] when viewed as admin and as another user.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/18