Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62638

Invalid CSS on Ordered Lists

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.3, 3.5, 3.6
    • Fix Version/s: 3.4.4, 3.5.1
    • Component/s: HTML and CSS, Themes
    • Labels:

      Description

      In theme/boost/scss/moodle/undo.less, there is the following code:

      // Extends bootstrapbase/less/bootstrap/type.less
      // to enable ol lists to use a larger number set.
       
      ol {
          margin: 0 0 $line-height-base / 2 2.5em;
      }
      

      But line-height doesn't have units, so it ends up with:

      margin: 0 0 .75 2.5em;

      Which the browser might ignore because of the lack of a unit on the third number.

      But, even if it was working it's not clear what it's doing. The comment suggests it's trying to increase the left margin, but it touches all of them, overwriting the bootstrap default for the bottom margin. Maybe it was based on code from Bootstrap 3 (the comment mentions .less files) but that value has changed since. So ideally it would just be deleted and leave the bootstrap defaults on ol tags.

        Attachments

          Activity

            People

            Assignee:
            basbrands Bas Brands
            Reporter:
            bawjaws David Scotson
            Peer reviewer:
            Mihail Geshoski
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Gladys Basiana
            Participants:
            Component watchers:
            Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Jul/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 10 minutes
                10m