Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62638

Invalid CSS on Ordered Lists

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.4.4, 3.5.1
    • 3.4.3, 3.5, 3.6
    • HTML and CSS, Themes

      In theme/boost/scss/moodle/undo.less, there is the following code:

      // Extends bootstrapbase/less/bootstrap/type.less
      // to enable ol lists to use a larger number set.
       
      ol {
          margin: 0 0 $line-height-base / 2 2.5em;
      }
      

      But line-height doesn't have units, so it ends up with:

      margin: 0 0 .75 2.5em;

      Which the browser might ignore because of the lack of a unit on the third number.

      But, even if it was working it's not clear what it's doing. The comment suggests it's trying to increase the left margin, but it touches all of them, overwriting the bootstrap default for the bottom margin. Maybe it was based on code from Bootstrap 3 (the comment mentions .less files) but that value has changed since. So ideally it would just be deleted and leave the bootstrap defaults on ol tags.

            basbrands Bas Brands
            bawjaws David Scotson
            Mihail Geshoski Mihail Geshoski
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Gladys Basiana Gladys Basiana
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 10 minutes
                10m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.