Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62654

Bootstrap 4 import process is not documented or maintainable.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.5.1
    • Component/s: Themes
    • Labels:

      Description

      The files in theme/boost/upgrade.txt and theme/boost/readme_moodle.txt do not describe exactly how or what this version of bootstrap is, and how it was created. Downloading a standard version of bootstrap 4.0.0 and running a diff between this and the one shipped with Moodle produces a random set of changes for things like popover, position, and carousel.

       

      Bootstrap source files should never be changed except in very rare uncontrollable situations, and then they should be clearly documented. We are now faced with a situation where we have an unknown version of bootstrap and have no clear documentation on how we should update to a newer version without introducing changes (4.1.1 for example).

       

        Attachments

          Activity

            People

            Assignee:
            basbrands Bas Brands
            Reporter:
            damyon Damyon Wiese
            Peer reviewer:
            Damyon Wiese
            Integrator:
            David Monllaó
            Tester:
            CiBoT
            Participants:
            Component watchers:
            Bas Brands
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Jul/18