[MDL-62658] Ensure clicked notifications are marked read - Regression: A required parameter (notificationid) was missing - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: 3.4.3, 3.5
Fix Version/s: 3.4.4, 3.5.1
Component/s: Messages
Labels:
- ci
- regression
- release_notes
- triaged

Affected Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Fixed Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Epic Link:
Messaging issues
Pull from Repository:
git://github.com/markn86/moodle.git
Pull Master Branch:
~~MDL-62658~~_master
Pull Master Diff URL:
https://github.com/markn86/moodle/compare/imaster...MDL-62658_master
Testing Instructions:
Hide

Log in as the admin.

Create a course.

Create a forum.

Add a new discussion topic.

Enrol a student into the course.

Log in as the student in another browser.

Click on the 'Notification' icon and then 'Notification preferences'.

Toggle it to 'On' for 'Web' notifications for 'Subscribed forum posts'.

Visit the course.

Reply to the forum post.

As the admin reply to the student's forum post and check 'Send forum post notifications with no editing-time delay'.

Run the cron.

As the student notice you have a notification.

Click on the notification.

Confirm it gets marked as read and you are directed to the forum.
Show
Log in as the admin. Create a course. Create a forum. Add a new discussion topic. Enrol a student into the course. Log in as the student in another browser. Click on the 'Notification' icon and then 'Notification preferences'. Toggle it to 'On' for 'Web' notifications for 'Subscribed forum posts'. Visit the course. Reply to the forum post. As the admin reply to the student's forum post and check 'Send forum post notifications with no editing-time delay'. Run the cron. As the student notice you have a notification. Click on the notification. Confirm it gets marked as read and you are directed to the forum.

Description

MDL-56498 message: Ensure clicked notifications are marked read

I get the error 'A required parameter (notification id) was missing' when I click in the link inside popup notifications. This behavior, I believe, is because the below code has an issue.
See:

// Link to mark read page before loading the actual link.
{{ notification.contexturl = URL.relativeUrl('message/output/popup/mark_notification_read.php', {}}
{{ redirecturl: notification.contexturl,}}
notificationid: notification.id,
{{ });}}

This will build an incorrect url path, like this:

http://<wwwroot>moodle/message/output/popup/mark_notification_read.php?redirecturl=http://<wwwroot>/moodle/mod/forum/discuss.php?d=684#p2916&notificationid=56608

A solution is change parameters order:

notificationid: notification.id, redirecturl: notification.contexturl,

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Verified_MDL-62658.png
68 kB
20/Jun/18 6:17 PM

Issue Links

is a regression caused by

MDL-56498 Notifications not being marked as read when click in popover

Closed

is blocked by

MDL-57968 Multiple unnecessary Messaging AJAX requests (core_message_get_unread_conversations_count, message_popup_get_unread_popup_notification_count) on all pages

Closed

Activity

People

Assignee:: Mark Nelson

Reporter:: Fernando Rocha

Peer reviewer:: Carlos Escobedo

Integrator:: Jun Pataleta

Tester:: Gladys Basiana

Participants:: Alexander Bias, Carlos Escobedo, CiBoT, Eloy Lafuente (stronk7), Fernando Rocha, Gladys Basiana, Jun Pataleta, Mark Nelson, Yana Konstantinovsky

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 3 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 07/Jun/18 5:42 AM

Updated:: 03/Jul/18 4:41 AM

Resolved:: 22/Jun/18 8:39 AM

Fix Release Date:: 9/Jul/18

Time Tracking

Estimated:

Remaining:

Logged:

40m