Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62668

Workshop web service does not return the feedback for the reviewer on assessment phase

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.3, 3.5, 3.6
    • Fix Version/s: 3.5.5, 3.6.3
    • Component/s: Workshop
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a course with a workshop
      2. Enrol a couple users as student (student2 and student1) and one user as teacher
      3. As teacher, move the workshop to the submission phase (doing all the required configuration steps indicated by the activity)
      4. As the two students, do a submission (total of 2 submissions, one per student).
      5. As teacher, move the workshop to the assessment phase, allocating the assessment of the submissions: student2 will assess student1 and vice versa.
      6. As the students, do your assessments (student2 will assess the submission done by student1 and vice versa)
      7. Enable "Mobile services": Site administration ► Mobile app ► Mobile settings
      8. Create a Token in the mobile app service for student1 and the teacher:
        • Click on Site administration ► Plugins ► Web services ► Manage tokens
      9. Next, you can do a CURL REST call simulating a WS client with the student.
        • You need to replace the $CFG->wwwroot, the wstoken with the teacher one, workshopid with the workshop id and userid with student1 id and the URL of your moodle instance

          curl 'http://localhost/m/stable_master/webservice/rest/server.php?moodlewsrestformat=json' --data 'workshopid=8&userid=136*&wsfunction=mod_workshop_get_reviewer_assessments&wstoken=12a2a65aeea2a177055e233f9e303218&moodlewssettingfilter=true' | python -m "json.tool"

      1. Now check that you receive the information of the submission assessments done by student1 (you will see just one assessment). Including a field called feedbackreviewer (that will be empty).
      2. Now, replace the wstoken with the student1 and execute the curl request, check that you receive correctly the assessments student1 did but not the feedbackreviewer field.
      3. As admin, move the assessment to the "Grading evaluation phase", execute the last CURL request and
        • Check that now you see the feedbackreviewer field
      Show
      Create a course with a workshop Enrol a couple users as student (student2 and student1) and one user as teacher As teacher, move the workshop to the submission phase (doing all the required configuration steps indicated by the activity) As the two students, do a submission (total of 2 submissions, one per student). As teacher, move the workshop to the assessment phase, allocating the assessment of the submissions: student2 will assess student1 and vice versa. As the students, do your assessments (student2 will assess the submission done by student1 and vice versa) Enable "Mobile services": Site administration ► Mobile app ► Mobile settings Create a Token in the mobile app service for student1 and the teacher: Click on Site administration ► Plugins ► Web services ► Manage tokens Next, you can do a CURL REST call simulating a WS client with the student. You need to replace the $CFG->wwwroot, the wstoken with the teacher one, workshopid with the workshop id and userid with student1 id and the URL of your moodle instance curl ' http://localhost/m/stable_master/ webservice/rest/server.php?moodlewsrestformat=json' --data 'workshopid= 8 &userid= 136 *&wsfunction=mod_workshop_get_reviewer_assessments&wstoken= 12a2a65aeea2a177055e233f9e303218 &moodlewssettingfilter=true' | python -m "json.tool" Now check that you receive the information of the submission assessments done by student1 (you will see just one assessment). Including a field called feedbackreviewer (that will be empty). Now, replace the wstoken with the student1 and execute the curl request, check that you receive correctly the assessments student1 did but not the feedbackreviewer field. As admin, move the assessment to the "Grading evaluation phase", execute the last CURL request and Check that now you see the feedbackreviewer field
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-62668-master

      Description

      The web service functions that return workshop assessments do not include the "feedbackreviewer" in the response if the workshop is on the assessment phase. In contrast, the function "evaluate_assessment" allows submitting the feedback for the reviewer on the assessment phase.

      This affects the mobile app, teachers are allowed to submit the feedback for the reviewer but then it is not displayed.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/19