[MDL-62691] Annotate PDF includes "close dialogue" cross in toolbar menus - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.5, 3.5 regressions
Fix Version/s: 3.5.1
Component/s: Assignment
Labels:
- ci
- regression
- triaged

Testing Instructions:
Hide

Login as teacher

Go to any course and enrol a student

Create a new assignment for file submissions

Login as student and add a file submission to the assignment

Login as teacher and grade the assignment

Click the stamps icon (red X)

Verify there is no close icon (black x) in the dropdown menu
Show
Login as teacher Go to any course and enrol a student Create a new assignment for file submissions Login as student and add a file submission to the assignment Login as teacher and grade the assignment Click the stamps icon (red X) Verify there is no close icon (black x) in the dropdown menu
Affected Branches:
MOODLE_35_STABLE
Fixed Branches:
MOODLE_35_STABLE
Epic Link:
Boost follow ups
Pull from Repository:
git://github.com/bmbrands/moodle.git
Pull 3.5 Branch:
~~MDL-62691~~-35
Pull 3.5 Diff URL:
https://github.com/bmbrands/moodle/compare/180988c999...MDL-62691-35
Pull Master Branch:
~~MDL-62691~~-master
Pull Master Diff URL:
https://github.com/bmbrands/moodle/compare/9e7c397889...MDL-62691-master

Description

The menus for the editpdf plugin are built with YUI and were previously (Moodle 3.4 and older) hidden. In master and Moodle 3.5 they are now displayed as a misleading looking entry in each menu from the PDF feedback feature in mod_assign.

To reproduce this, grade a submission in mod_assign. In the pdf window click on the stamps icon to show a list of the installed stamps on this Moodle site.

If the first stamp shows as a black X, this is the problem. Clicking on the X closes the menu but does not change anything else.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

MDL-62691.PNG
17 kB
04/Jul/18 5:59 PM

Activity

People

Assignee:: Bas Brands

Reporter:: Damyon Wiese

Peer reviewer:: Damyon Wiese

Integrator:: David Monllaó

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, Bas Brands, CiBoT, Damyon Wiese, David Monllaó, Eloy Lafuente (stronk7)

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 12/Jun/18 10:29 PM

Updated:: 07/Jul/18 2:19 AM

Resolved:: 07/Jul/18 2:19 AM

Fix Release Date:: 9/Jul/18

Time Tracking

Estimated:

Remaining:

Logged:

30m