Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62691

Annotate PDF includes "close dialogue" cross in toolbar menus

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.5, 3.5 regressions
    • Fix Version/s: 3.5.1
    • Component/s: Assignment
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-62691-master
    • Testing Instructions:
      Hide
      1. Login as teacher
      2. Go to any course and enrol a student
      3. Create a new assignment for file submissions
      4. Login as student and add a file submission to the assignment
      5. Login as teacher and grade the assignment
      6. Click the stamps icon (red X)
      7. Verify there is no close icon (black x) in the dropdown menu
      Show
      Login as teacher Go to any course and enrol a student Create a new assignment for file submissions Login as student and add a file submission to the assignment Login as teacher and grade the assignment Click the stamps icon (red X) Verify there is no close icon (black x) in the dropdown menu

      Description

      The menus for the editpdf plugin are built with YUI and were previously (Moodle 3.4 and older) hidden. In master and Moodle 3.5 they are now displayed as a misleading looking entry in each menu from the PDF feedback feature in mod_assign.

      To reproduce this, grade a submission in mod_assign. In the pdf window click on the stamps icon to show a list of the installed stamps on this Moodle site. 

      If the first stamp shows as a black X, this is the problem. Clicking on the X closes the menu but does not change anything else.

       

       

        Attachments

        1. MDL-62691.PNG
          17 kB
          Anna Carissa Sadia

          Activity

            People

            Assignee:
            basbrands Bas Brands
            Reporter:
            damyon Damyon Wiese
            Peer reviewer:
            Damyon Wiese Damyon Wiese
            Integrator:
            David Monllaó David Monllaó
            Tester:
            Anna Carissa Sadia Anna Carissa Sadia
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Jul/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 30 minutes
                30m