Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62746

The layout of the content of core_tag modals don't look okay in BS4 stable

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Note: Test on Boost and Clean

      Tag collections
      1. Log in as an admin
      2. Go to "Site administration / Appearance / Manage tags"
      3. Click on "Add tag collection"
      4. Confirm that "Add tag collection" modal comes up
      5. Confirm that the form's layout inside the "Add tag collection" modal looks okay
        MASTER ONLY START
      6. Click on "Cancel"
      7. Confirm that the modal closes.
      8. Click again on "Add tag collection"
      9. Click on "Create" without entering anything in the "Name" field.
      10. Confirm that you get a validation message that the field is required.
        MASTER ONLY END
      11. Enter something in the "Name" field.
      12. Confirm that you can successfully create a tag collection.
      Adding standard tags
      1. Continuing from the previous section, click on the tag collection that you created.
      2. Click "Add standard tags"
      3. Confirm that "Add standard tags" modal comes up
      4. Confirm that the form's layout inside the "Add standard tags" modal looks okay
        MASTER ONLY START
      5. Click on "Cancel"
      6. Confirm that the modal closes.
      7. Click again on "Add standard tags"
      8. Click on "Continue" without entering anything in the "Enter comma-separated list of new tags" field.
      9. Confirm that you get a validation message that the field is required.
        MASTER ONLY END
      10. Enter a list of comma-separated list of new tags and click "Continue"
      11. Confirm that the tags are created and added to the list.
      Combining tags
      1. Continuing from the previous section, tick at least 2 of the tags that you created.
      2. Click on "Combine selected"
      3. Confirm that "Combine selected" modal comes up
      4. Confirm that the form's layout inside the "Combine selected" modal looks okay
      5. Confirm that the first option in the list of the tags to be combined is ticked.
      6. Click on "Cancel"
      7. Confirm that the modal closes.
      8. Click again on "Combine selected"
      9. Tick on the second option and click "Continue"
      10. Confirm that you see a message that the tags have been combined.
      11. Confirm that the option you selected is shown in the tags list and the others have been removed.
      Show
      Note: Test on Boost and Clean Tag collections Log in as an admin Go to " Site administration / Appearance / Manage tags " Click on " Add tag collection " Confirm that " Add tag collection " modal comes up Confirm that the form's layout inside the " Add tag collection " modal looks okay MASTER ONLY START Click on " Cancel " Confirm that the modal closes. Click again on " Add tag collection " Click on " Create " without entering anything in the " Name " field. Confirm that you get a validation message that the field is required. MASTER ONLY END Enter something in the " Name " field. Confirm that you can successfully create a tag collection. Adding standard tags Continuing from the previous section, click on the tag collection that you created. Click " Add standard tags " Confirm that " Add standard tags " modal comes up Confirm that the form's layout inside the " Add standard tags " modal looks okay MASTER ONLY START Click on " Cancel " Confirm that the modal closes. Click again on " Add standard tags " Click on " Continue " without entering anything in the " Enter comma-separated list of new tags " field. Confirm that you get a validation message that the field is required. MASTER ONLY END Enter a list of comma-separated list of new tags and click " Continue " Confirm that the tags are created and added to the list. Combining tags Continuing from the previous section, tick at least 2 of the tags that you created. Click on " Combine selected " Confirm that " Combine selected " modal comes up Confirm that the form's layout inside the " Combine selected " modal looks okay Confirm that the first option in the list of the tags to be combined is ticked. Click on " Cancel " Confirm that the modal closes. Click again on " Combine selected " Tick on the second option and click " Continue " Confirm that you see a message that the tags have been combined. Confirm that the option you selected is shown in the tags list and the others have been removed.
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull 3.4 Branch:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-62746-master

      Description

      A lot of these are forms inside the modal that don't follow the guidelines in the Bootstrap docs.

      1. Add tag collection
      2. Combine selected tags

        Attachments

        1. 1.PNG
          1.PNG
          103 kB
        2. 2.PNG
          2.PNG
          102 kB
        3. 3.PNG
          3.PNG
          73 kB
        4. Add tag collection.png
          Add tag collection.png
          15 kB
        5. Combine selected.png
          Combine selected.png
          20 kB
        6. master-add-standard-tags.png
          master-add-standard-tags.png
          19 kB
        7. master-add-tag-collection.png
          master-add-tag-collection.png
          24 kB
        8. master-combine-tags.png
          master-combine-tags.png
          16 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 34 minutes
                  34m