[MDL-62757] Validate boost presets before allowing to pick and use them - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5, 3.8, 3.9
Fix Version/s: 3.9
Component/s: Themes
Labels:

Testing Instructions:
Hide

Login as admin.

Navigate to Site Administration > Appearance > Themes > Boost

Upload the 3 Boost presets attached to this issue.

Save changes

Choose the "Litera" template in field "Theme Preset"

Reload the page

Verify you see some theme changes

Choose the "Yeti" template in field "Theme Preset"

You should receive a notification the preset did not compile.

Navigate to Site Administration > Appearance > Themes > Boost again

Verify the "Litera" template is still the chosen template.
Show
Login as admin. Navigate to Site Administration > Appearance > Themes > Boost Upload the 3 Boost presets attached to this issue. Save changes Choose the "Litera" template in field "Theme Preset" Reload the page Verify you see some theme changes Choose the "Yeti" template in field "Theme Preset" You should receive a notification the preset did not compile. Navigate to Site Administration > Appearance > Themes > Boost again Verify the "Litera" template is still the chosen template.
Affected Branches:
MOODLE_35_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_39_STABLE
Pull from Repository:
git://github.com/bmbrands/moodle.git
Pull Master Branch:
~~MDL-62757~~-master
Pull Master Diff URL:
https://github.com/bmbrands/moodle/compare/800563e415...MDL-62757-master

Sprint:
Moppies Moodle 3.8 Sprint 5, Moppies Moodle 3.8 Sprint 6, Moodle 3.9 - Moppies Kanban

Description

With the upgrade to Bootstrap 4 Stable preset files have changed. Older presets or presets using the wrong variables cause the CSS compiler to fail and leave Moodle unstyled

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

Confirmed fixed.png
182 kB
05/Dec/19 9:17 AM
litera.scss
7 kB
06/Aug/19 11:20 PM
lumen.scss
19 kB
06/Aug/19 11:20 PM
merged.png
841 kB
27/Nov/19 12:40 AM
yeti.scss
10 kB
06/Aug/19 11:20 PM

Activity

People

Assignee:: Bas Brands

Reporter:: Bas Brands

Peer reviewer:: Ferran Recio

Integrator:: Eloy Lafuente (stronk7)

Tester:: Gladys Basiana

Participants:: Bas Brands, CiBoT, Eloy Lafuente (stronk7), Ferran Recio, Gladys Basiana, Ryan Wyllie

Component watchers:: Bas Brands

Votes:: 0 Vote for this issue

Watchers:: 8 Start watching this issue

Dates

Created:: 20/Jun/18 11:44 PM

Updated:: 05/Dec/19 8:45 PM

Resolved:: 05/Dec/19 8:45 PM

Fix Release Date:: 15/Jun/20

Time Tracking

Estimated:

Remaining:

Logged:

1d 18m