Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62757

Validate boost presets before allowing to pick and use them

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Login as admin.
      2. Navigate to Site Administration > Appearance > Themes > Boost
      3. Upload the 3 Boost presets attached to this issue.
      4. Save changes
      5. Choose the "Litera" template in field "Theme Preset"
      6. Reload the page
      7. Verify you see some theme changes
      8. Choose the "Yeti" template in field "Theme Preset"
      9. You should receive a notification the preset did not compile.
      10. Navigate to Site Administration > Appearance > Themes > Boost again
      11. Verify the "Litera" template is still the chosen template.
      Show
      Login as admin. Navigate to Site Administration > Appearance > Themes > Boost Upload the 3 Boost presets attached to this issue. Save changes Choose the "Litera" template in field "Theme Preset" Reload the page Verify you see some theme changes Choose the "Yeti" template in field "Theme Preset" You should receive a notification the preset did not compile. Navigate to Site Administration > Appearance > Themes > Boost again Verify the "Litera" template is still the chosen template.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-62757-master
    • Pull Master Diff URL:
    • Sprint:
      Moppies Moodle 3.8 Sprint 5, Moppies Moodle 3.8 Sprint 6, Moodle 3.9 - Moppies Kanban

      Description

      With the upgrade to Bootstrap 4 Stable preset files have changed. Older presets or presets using the wrong variables cause the CSS compiler to fail and leave Moodle unstyled

        Attachments

        1. Confirmed fixed.png
          Confirmed fixed.png
          182 kB
        2. litera.scss
          7 kB
        3. lumen.scss
          19 kB
        4. merged.png
          merged.png
          841 kB
        5. yeti.scss
          10 kB

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/20

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 18 minutes
                1d 18m