Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62762

Catch indexing document exceptions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.4.3, 3.5
    • Fix Version/s: None
    • Component/s: Global search
    • Labels:
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE

      Description

      In MDL-60943 a test was added that catches bad preg_match output due to unexpected characters in the input.

      While this is a good thing overall, that exception is never caught, and so kills all of indexing. We just noticed that none of our search areas have been in 2.5 months, because the first thing it tries to index is a block_html that is bad, and then dies. This causes the entire task to die. And now it does that once a day - tries to index and then dies immediately.

      My personal opinion is that the moodle_execption (with it 'error_indexing') should be caught, maybe in the engine add_documents, logged, and then that document skipped.

      At the very least, a failing search area shouldn't cause all search areas to not be indexed...

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                emerrill Eric Merrill
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: