[MDL-62792] Minor issues with filters - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.4.3, 3.5, 3.6
Fix Version/s: 3.4.4, 3.5.1
Component/s: Filters, Maths filters
Labels:
- ci
- triaged

Affected Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Pull from Repository:
https://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-62792~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-62792
Testing Instructions:

Hide

A CI run should be sufficient to verify that this code clean-up does not cause any regressions.

Show
A CI run should be sufficient to verify that this code clean-up does not cause any regressions.

Description

I am creating a new filter plugin, and noticing various errors in the core filters that my IDE is flagging up. It seems worth submitting fixes for integration.

Bad php docs.
Bad use of static in filter_mathjaxhelper.

Attachments

Activity

People

Assignee:: Tim Hunt

Reporter:: Tim Hunt

Peer reviewer:: David Mudrák (@mudrd8mz)

Integrator:: Eloy Lafuente (stronk7)

Tester:: CiBoT

Participants:: CiBoT, David Mudrák (@mudrd8mz), Eloy Lafuente (stronk7), Tim Hunt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 26/Jun/18 6:01 AM

Updated:: 07/Jul/18 2:19 AM

Resolved:: 07/Jul/18 2:19 AM

Fix Release Date:: 9/Jul/18