Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62796

tool_policy does not show popup for users who are not logged in and not logged in as guests

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Make sure the $CFG->sitepolicyhandler is set to tool_policy
      2. Create one active policy that is for guests only, one policy for authenticated users only and one policy for all users
      3. Add a forum to the frontpage and post something there
      4. Try different combinations of settings $CFG->forcelogin, $CFG->autologinguests, $CFG->guestloginbutton
      5. Make sure to close and open new incognito window each time you change settings (or purge browser cache & cookies)
      6. As a user who is not logged in make sure that the popup is displayed on every page including: frontpage, login page, signup page, frontpage forum regardless of whether you are logged in as a guest or not
      7. Make sure all links in the popup work and authenticated-users-only policy is not displayed
      Show
      Make sure the $CFG->sitepolicyhandler is set to tool_policy Create one active policy that is for guests only, one policy for authenticated users only and one policy for all users Add a forum to the frontpage and post something there Try different combinations of settings $CFG->forcelogin, $CFG->autologinguests, $CFG->guestloginbutton Make sure to close and open new incognito window each time you change settings (or purge browser cache & cookies) As a user who is not logged in make sure that the popup is displayed on every page including: frontpage, login page, signup page, frontpage forum regardless of whether you are logged in as a guest or not Make sure all links in the popup work and authenticated-users-only policy is not displayed
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull 3.5 Branch:
      wip-MDL-62796-35
    • Pull Master Branch:
      wip-MDL-62796-master

      Description

      When working on tool_policy we implemented the same logic as what $CFG->sitepolicyguests did - policies are shown only to users who are logged in as guests.

      However Moodle sends cookie even for users who are not logged in at all, which means that we need to display popup even in this case

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jul/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 22 minutes
                  22m