Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62807

Bullets appear in 'Course and category management' page

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Switch theme to "clean"

      1. As an admin go to "Site administration -> Courses -> Manage courses and categories
      2. Create 2 sub categories of the "Miscellaneous" category
      3. Create sub more sub categories of the first sub category you created in the previous step
      4. Verify none of the lists (or sub lists) in the "Course categories" section of the page have bullets
      5. Verify you can expand and collapse the categories by clicking on the expand / collapse icons
      6. Verify you can use the keyboard to "tab" to the expand collapse icons and use them with the enter key
      7. Verify the categories at the bottom of the nested tree do not have expand / collapse images
      8. Verify you cannot hover with the mouse over the not displayed expand / collapse images and see any alt text

      Switch theme to "boost"

      • Repeat all the steps that were performed with the "clean" theme

       

      Show
      Switch theme to "clean" As an admin go to "Site administration -> Courses -> Manage courses and categories Create 2 sub categories of the "Miscellaneous" category Create sub more sub categories of the first sub category you created in the previous step Verify none of the lists (or sub lists) in the "Course categories" section of the page have bullets Verify you can expand and collapse the categories by clicking on the expand / collapse icons Verify you can use the keyboard to "tab" to the expand collapse icons and use them with the enter key Verify the categories at the bottom of the nested tree do not have expand / collapse images Verify you cannot hover with the mouse over the not displayed expand / collapse images and see any alt text Switch theme to "boost" Repeat all the steps that were performed with the "clean" theme  
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-62807-master

      Description

      Moodle 3.5 (Build 20180517)

      Steps to reproduce the problem:

      1. Goto Site administration > Courses > Manage courses and categories
      2. Observe that in the list of course categories, each list item has a bullet, where in previous version of Moodle there were no bullets. 

      In previous versions of Moodle, the bullets were hidden because each <ul> tag had a class of 'ml'.  A style rule with a selector of '#course-category-listing ul.ml' would match the <ul> tag, and apply a 'list-style: none;' property to the <ul> tag.

      In the current version of Moodle, each <ul> tag now has a class of 'ml-1'.  No style rule selector matches that, so the bullets appear.

      The PHP code responsible for giving the <ul> tag the class is in moodle/course/classes/management_renderer.php, in several places:

      • function category_listing()
      • function category_listitem()
      • function course_listing()
      • function search_listing()

      The problem happens regardless of what theme is applied.

      There are two options for fixing for the problem.

      1. Change management_renderer.php to revert back to giving the <ul> tags a class of 'ml' instead of 'ml-1'.
      2. Change the rule in the stylesheets to adapt to the new class of 'ml-1'.

      I do not know the reason why the class for these <ul> tags was changed, so I cannot suggest which option is preferable.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                damyon Damyon Wiese
                Reporter:
                leviculus Mike Finch
                Peer reviewer:
                Bas Brands
                Integrator:
                Jun Pataleta
                Tester:
                Janelle Barcega
                Participants:
                Component watchers:
                Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Amy Groshek, David Scotson, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h