[MDL-62814] Question: Column base does not support custom tip if sortable is an array - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.4.3, 3.5
Fix Version/s: 3.4.5, 3.5.2
Component/s: Questions
Labels:
- ci
- patch
- triaged

Testing Instructions:

Hide

This can be test by using class extends column_base and return array for is_sortable function

Show
This can be test by using class extends column_base and return array for is_sortable function
Affected Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Fixed Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Pull from Repository:
https://github.com/HuongNV13/moodle
Pull 3.5 Branch:
~~MDL-62814~~-35
Pull 3.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_35_STABLE...HuongNV13:MDL-62814-35
Pull Master Branch:
~~MDL-62814~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...HuongNV13:MDL-62814-master

Description

Function column_base::is_sortable() support to return an column name (string) or multiple columns (array)

Currently, column_base::display_header() only support custom tip when is_sortable return a string, if it returns an array, the function will use the title for the tip also

We need to support custom tip for array case also

Attachments

Activity

People

Assignee:

Huong Nguyen

Reporter:

Huong Nguyen

Peer reviewer:

Tim Hunt

Integrator:

David Monllaó

Tester:

CiBoT

Participants:

CiBoT, David Monllaó, Huong Nguyen, Tim Hunt

Component watchers:

Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:

0 Vote for this issue

Watchers:

2 Start watching this issue

Dates

Created:

27/Jun/18 11:27 PM

Updated:

13/Jul/18 11:08 PM

Resolved:

13/Jul/18 11:08 PM

Fix Release Date:

10/Sep/18