Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62836

Make awarding badges groups/groupings compliant

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      1. Enable Badges at site level and course level
        • Go to Site Administration > Advanced Features > Enable badges
        • Go to Site Administration > Badges > Badges settings > Enable course badges
      2. Create a course and choose Separate groups as Group mode
      3. Create a Badge in the Course using the following settings:
        • Badge details (mandatory fields don’t have specific impact on this test)
        • Criteria:
          1. Select > Manual issue by role
            • Check Non-editing teacher and Teacher
          2. This criterion is complete when > Any of the selected roles awards the badge
          3. Click Save
        • Click to Enable access > Continue
      4. Create some users into the site, like person1 (2, 3, 4…) with one or two to be a teacher. Enrol them as student or non-editing teacher accordingly on the course.
      5. Create some groups manually or automatically and add the users created
        • Auto-create groups
          1. Use naming scheme as default Group @
          2. Change Auto create based on Members per group
          3. On Group/member count: choose 2 or 3 depending on the numbers of users created
          4. Select members with role: Student
          5. On Grouping, create a new grouping with the name School1. Click Submit.
        • Add the non-editing teacher to more than one of those groups.
      6. Create some more users, like user1 (2, 3, 4…) in order to distinguish them easily when groups are setup, with one or two to be a teacher. Enrol them as a student or non-editing teacher accordingly on the course.
        • Auto-create some more groups but with a Naming scheme like Group # and a New grouping with a different name like School2.
        • Add the new non-editing teacher to one or more of these groups.
      7. Create another user like teacher1, enrol him as teacher and add him to one of the groups created.

      Testing scenario 1 (Separate groups)

      1. Login and access as non-editing teacher to the course, e.g. person1;
        1. Under Course Administration, select Manage badges;
        2. On the available badge, click the award badge icon;
        3. Select the role you would like to use to award this badge;
        4. Check that below Badge recipients, there is a Separate groups label and a dropdown menu matching the groups you were added to.
        5. Check that the list of Potential badge recipients only displays the users belonging the group selected by default, e.g. person2, 3… and not user1, 2…
        6. Check that when changing the group selected, the list of Potential badge recipients updates according to the selection made, i.e., containing only the members of that group.
        7. Select one user and click Award badge. Check that the list of Existing badge recipients is updated with the user selected and displaying only the users belonging to your group.
      2. Login and access as teacher to the course, e.g. teacher1;
        1. Go to Manage badges and click the award badge icon;
        2. Select the role you would like to use to award this badge;
        3. Check that below Badge recipients, there is a Separate groups label and a dropdown menu with different options, such as:
          1. All participants
          2. My groups (should match the ones you belong to)
          3. Other groups (the remaining groups of the current course)
        4. Check that when changing the group selected, both lists of Potential badge recipients and Existing badge recipients are updated according to the selection made, i.e., containing only the members of that group.
      3. Login and access as admin to the course;
        1. Go to Manage badges and click the award badge icon;
        2. Select the role you would like to use to award this badge;
        3. Check that below Badge recipients, there is a Separate groups label and a dropdown menu with an option to select All participants and options for all the groups of the current course.
        4. Check that when changing the group selected, both lists of Potential badge recipients and Existing badge recipients are updated according to the selection made, i.e., containing only the members of that group.
        5. Note: if you select the non-editing teacher role, then you should see the Existing badge recipients box with the user awarded on the previous scenario, when selecting his group.

      Testing scenario 1.1 (Separate groups - with one group)

      1. As admin, change the setup under Course Administration > Users > Groups
        • Leave the non-editing teacher user belonging to just one group of the course.
      2. Login and access as non-editing teacher to the course, e.g. person1;
        1. Under Course Administration, select Manage badges;
        2. On the available badge, click the award badge icon;
        3. Select the role you would like to use to award this badge;
        4. Check that below Badge recipients, there are two labels, one for Separate groups and another for the group you belong to.
        5. Check that both lists of Potential badge recipients and Existing badge recipients contain only the members of that group.

      Testing scenario 1.2 (Separate groups - without groups)

      1. As admin, change the setup under Course Administration > Users > Groups
        • Remove the non-editing teacher user from all the groups of the course.
      2. Login and access as non-editing teacher to the course, e.g. person1;
        1. Under Course Administration, select Manage badges;
        2. On the available badge, click the award badge icon;
        3. Check that you see the following message: Sorry, but you need to be part of a group to see this page.

      Testing scenario 2 (Visible groups)

      1. As admin, change the setup under Course Administration > Edit settings to Visible groups;
      2. Login and access as non-editing teacher to the course, e.g. person1;
        1. Under Course Administration, select Manage badges;
        2. On the available badge, click the award badge icon;
        3. Select the role you would like to use to award this badge;
        4. Check that below Badge recipients, there is a Visible groups label and a dropdown menu with different options, such as:
          1. All participants
          2. My groups (should match the ones you belong to)
          3. Other groups (the remaining groups of the current course)
        5. Check that the list of Potential badge recipients only displays the users belonging the group selected by default, e.g. person2, 3… and not user1, 2…
        6. Check that when changing the group selected, the list of Potential badge recipients updates according to the selection made, i.e., containing only the members of that group.
        7. Select one user and click Award badge. The list of Existing badge recipients should be updated with the user selected and displaying only the users belonging to that group.
      3. When logging as teacher or admin, the results should be the same.

      Testing scenario 3 (No groups)

      1. As admin, change the setup under Course Administration > Edit settings to No groups;
      2. Login and access as non-editing teacher to the course, e.g. person1;
        1. Under Course Administration, select Manage badges;
        2. On the available badge, click the award badge icon;
        3. Check that below Badge recipients there is nothing besides the Existing badge recipients box.
        4. Check that the list of Potential badge recipients displays all the users of the course, e.g. person2, 3… and user1, 2… if they don't have that badge already;
        5. Select one user and click Award badge. The list of Existing badge recipients should be updated with the user selected and the rest of the users who got that badge already.
      3. When logging as teacher or admin, the results should be the same.

       

      Show
      Setup Enable Badges at site level and course level Go to Site Administration > Advanced Features > Enable badges Go to Site Administration > Badges > Badges settings > Enable course badges Create a course and choose Separate groups as Group mode Create a  Badge in the  Course  using the following settings: Badge details (mandatory fields don’t have specific impact on this test) Criteria: Select > Manual issue by role Check  Non-editing teacher and T eacher This criterion is complete when > Any of the selected roles awards the badge Click Save Click to Enable access > Continue Create some users into the site, like person1 (2, 3, 4…) with one or two to be a teacher.  Enrol them as student or non-editing teacher accordingly on the course. Create some groups manually or automatically and add the users created Auto-create groups Use naming scheme as default Group @ Change Auto create based on Members per group On Group/member count : choose 2 or 3 depending on the numbers of users created Select members with role: Student On Grouping , create a new grouping with the name School1 . Click Submit . Add the non-editing teacher to more than one of those groups. Create some more users, like user1 (2, 3, 4…) in order to distinguish them easily when groups are setup, with one or two to be a teacher. Enrol them as a student or non-editing teacher accordingly on the course. Auto-create some more groups but with a Naming scheme like Group # and a New grouping with a different name like School2 . Add the new non-editing teacher to one or more of these groups. Create another user like teacher1 , enrol him as teacher and add him to one of the groups created. Testing scenario 1 (Separate groups) Login and access as non-editing teacher  to the course, e.g. person1 ; Under Course Administration , select Manage badges ; On the available badge, click the award badge icon ; Select the role you would like to use to award this badge; Check that below Badge recipients , there is a Separate groups label and a dropdown menu matching the groups you were added to. Check that the list of Potential badge recipients only displays the users belonging the group selected by default, e.g. person2, 3… and not user1, 2… Check that when changing the group selected, the list of Potential badge recipients   updates according to the selection made, i.e., containing only the members of that group . Select one user and click Award badge . Check that the list of Existing badge recipients is updated with the user selected and displaying only the users belonging to your group . Login and access as  teacher to the course, e.g. teacher1 ; Go to Manage badges and click the  award badge icon ; Select the role you would like to use to award this badge; Check that below Badge recipients , there is a Separate groups label and a dropdown menu with different options, such as: All participants My groups  (should match the ones you belong to) Other groups  (the remaining groups of the current course) Check that when changing the group selected, both lists of  Potential badge recipients  and  Existing badge recipients  are updated according to the selection made, i.e., containing only the members of that group . Login and access as admin  to the course; Go to Manage badges and click the  award badge icon ; Select the role you would like to use to award this badge; Check that below Badge recipients , there is a Separate groups label and a dropdown menu with an option to select All participants  and options for all the groups of the current course. Check that when changing the group selected, both lists of  Potential badge recipients  and  Existing badge recipients  are updated according to the selection made, i.e., containing only the members of that group . Note: if you select the non-editing teacher  role, then you should see the Existing badge recipients  box with the user awarded on the previous scenario , when selecting his group. Testing scenario 1.1 (Separate groups - with one group) As admin, change the setup under Course Administration > Users > Groups Leave the non-editing teacher user belonging to just one group of the course. Login and access as non-editing teacher  to the course, e.g. person1 ; Under Course Administration , select Manage badges ; On the available badge, click the award badge icon ; Select the role you would like to use to award this badge; Check that below Badge recipients , there are two labels, one for  Separate groups  and another for the group you belong to. Check that both lists of  Potential badge recipients  and  Existing badge recipients  contain only the members of that group. Testing scenario 1.2 (Separate groups - without groups) As admin, change the setup under Course Administration > Users > Groups Remove the non-editing teacher user from all the groups of the course. Login and access as non-editing teacher  to the course, e.g. person1 ; Under Course Administration , select Manage badges ; On the available badge, click the award badge icon ; Check that you see the following message: Sorry, but you need to be part of a group to see this page. Testing scenario 2 (Visible groups) As admin, change the setup under Course Administration > Edit settings to Visible groups ; Login and access as non-editing teacher  to the course, e.g. person1 ; Under Course Administration , select Manage badges ; On the available badge, click the award badge icon ; Select the role you would like to use to award this badge; Check that below Badge recipients , there is a Visible groups label and a dropdown menu with different options, such as: All participants My groups  (should match the ones you belong to) Other groups  (the remaining groups of the current course) Check that the list of Potential badge recipients only displays the users belonging the group selected by default, e.g. person2, 3… and not user1, 2… Check that when changing the group selected, the list of Potential badge recipients   updates according to the selection made, i.e., containing only the members of that group . Select one user and click Award badge . The list of Existing badge recipients should be updated with the user selected and displaying only the users belonging to that group . When logging as teacher or admin , the results should be the same. Testing scenario 3 (No groups) As admin, change the setup under Course Administration > Edit settings to No groups ; Login and access as non-editing teacher  to the course, e.g. person1 ; Under Course Administration , select Manage badges ; On the available badge, click the award badge icon ; Check that below Badge recipients  there is nothing besides the  Existing badge recipients box. Check that the list of Potential badge recipients displays  all the users of the course, e.g. person2, 3… and  user1, 2…  if they don't have that badge already; Select one user and click Award badge . The list of Existing badge recipients should be updated with the user selected and the rest of the users who got that badge already . When logging as teacher or admin , the results should be the same.  
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-62836-master

      Description

      We usually use the "separate groups" feature under the Course Administration, so each teacher only sees their class information of their own students.

      We would like to enable award badges by role, but at the moment, the teacher can see everyone enrolled on the course, which doesn't make sense according to our setup.

      I have removed the possibility of seeing Participants and Access to all groups but it doesn't have any impact.

      Our setup:

      • Create different groupings for different schools;
      • Create groups for each grouping;
      • Add teachers/students to grouping;
      • Teachers/students can add themselves to their group;

      Steps to reproduce the issue:

      • create badge that can be issued by role, in this case, teacher;
      • enable badge;
      • login as teacher;
      • under Course Administration, select manage badges;
      • on the available badge, click on recipients;
      • click award badge button;
      • on the list of "Potential badge recipients" there should only be the ones belonging to his grouping. Maybe have a filter by Group, like the Grader report.

        Attachments

        1. badge recipients view.png
          badge recipients view.png
          140 kB
        2. filter by group.png
          filter by group.png
          28 kB
        3. grader report by group.png
          grader report by group.png
          61 kB
        4. image-2018-11-22-12-11-45-011.png
          image-2018-11-22-12-11-45-011.png
          35 kB
        5. image-2018-11-28-09-50-32-411.png
          image-2018-11-28-09-50-32-411.png
          101 kB
        6. image-2018-11-28-09-52-08-282.png
          image-2018-11-28-09-52-08-282.png
          97 kB
        7. image-2018-11-28-15-52-26-598.png
          image-2018-11-28-15-52-26-598.png
          51 kB
        8. image-2018-11-28-15-55-52-999.png
          image-2018-11-28-15-55-52-999.png
          27 kB
        9. image-2018-11-28-16-10-34-889.png
          image-2018-11-28-16-10-34-889.png
          11 kB
        10. image-2018-11-29-15-51-49-875.png
          image-2018-11-29-15-51-49-875.png
          21 kB
        11. image-2018-11-29-15-52-46-972.png
          image-2018-11-29-15-52-46-972.png
          105 kB
        12. image-2018-11-29-15-53-03-155.png
          image-2018-11-29-15-53-03-155.png
          26 kB
        13. image-2018-11-30-10-48-29-158.png
          image-2018-11-30-10-48-29-158.png
          22 kB
        14. image-2018-11-30-10-50-00-029.png
          image-2018-11-30-10-50-00-029.png
          10 kB
        15. image-2018-11-30-11-36-52-479.png
          image-2018-11-30-11-36-52-479.png
          10 kB
        16. image-2018-12-05-13-24-53-991.png
          image-2018-12-05-13-24-53-991.png
          99 kB
        17. image-2019-01-15-15-12-38-929.png
          image-2019-01-15-15-12-38-929.png
          65 kB
        18. image-2019-01-15-15-12-51-029.png
          image-2019-01-15-15-12-51-029.png
          13 kB
        19. image-2019-01-15-15-13-08-917.png
          image-2019-01-15-15-13-08-917.png
          64 kB
        20. image-2019-01-15-15-13-33-142.png
          image-2019-01-15-15-13-33-142.png
          64 kB
        21. image-2019-01-15-15-14-40-123.png
          image-2019-01-15-15-14-40-123.png
          31 kB
        22. image-2019-02-25-11-36-10-976.png
          image-2019-02-25-11-36-10-976.png
          22 kB
        23. image-2019-02-25-11-44-20-439.png
          image-2019-02-25-11-44-20-439.png
          27 kB
        24. image-2019-02-25-11-55-16-414.png
          image-2019-02-25-11-55-16-414.png
          19 kB
        25. image-2019-02-25-11-56-11-208.png
          image-2019-02-25-11-56-11-208.png
          19 kB
        26. image-2019-06-13-13-01-02-337.png
          image-2019-06-13-13-01-02-337.png
          6 kB
        27. image-2019-06-13-13-01-41-848.png
          image-2019-06-13-13-01-41-848.png
          24 kB
        28. Screenshot_1.png
          Screenshot_1.png
          171 kB
        29. Screenshot_2.png
          Screenshot_2.png
          287 kB
        30. Screenshot_3.png
          Screenshot_3.png
          180 kB

          Activity

            People

            • Assignee:
              silviapinheiro Silvia Pinheiro
              Reporter:
              silviapinheiro Silvia Pinheiro
              Peer reviewer:
              Sara Arjona (@sarjona)
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Yuliya Bozhko, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Nov/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 6 hours, 20 minutes
                6h 20m