[MDL-62853] Writer does not sanitise or shorten filenames in the subcontext - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.3.6, 3.4.3, 3.5.1, 3.8.3, 3.9
Fix Version/s: 3.8.4
Component/s: Privacy
Labels:
- ci
- triaged

Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE
Epic Link:
GDPR Followups
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Master Branch:
~~MDL-62853~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-62853
Testing Instructions:

Hide

Should be covered by unit tests:

$ vendor/bin/phpunit moodle_content_writer_test privacy/tests/moodle_content_writer_test.php

Show
Should be covered by unit tests: $ vendor/bin/phpunit moodle_content_writer_test privacy/tests/moodle_content_writer_test.php

Description

The filename part from the context is both sanitized (clean_param), and shortened, but the subcontext is not.

Attachments

Issue Links

caused a regression

MDL-68875 moodle_content_writer_test failures with Windows

Closed

will be (partly) resolved by

MDL-62240 Export fails if some of the paths has more than 255 characters

Closed

Activity

People

Assignee:: Paul Holden

Reporter:: Andrew Lyons

Peer reviewer:: Peter Dias

Integrator:: Jake Dallimore

Tester:: CiBoT

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Jake Dallimore, Paul Holden, Peter Dias

Component watchers:: Andrew Lyons, Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 05/Jul/18 3:46 PM

Updated:: 29/May/20 11:15 PM

Resolved:: 27/May/20 5:23 AM

Fix Release Date:: 13/Jul/20

Time Tracking

Estimated:

Not Specified

Remaining:

0m

Logged:

1h 15m