Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62883

The LTI provider tool_consumer_instance_guid check was erroneously deleted

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.4.4, 3.5
    • Fix Version/s: None
    • Component/s: LTI provider
    • Labels:
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE

      Description

      I received this email from Stephen Vickers -

      I noticed this pull request from you in the now archived repository; see

      https://github.com/IMSGlobal/LTI-Tool-Provider-Library-PHP/pull/47

      I just wanted to point out that this parameter is only required when the
      protected status of a Tool Consumer is enabled; this is the purpose of
      this flag so removing the check undermines having this option. If you
      wish to allow a Tool Consumer to not send the
      tool_consumer_instance_guid parameter, then just do not enable the
      protected option in its record.

      We applied this fix manually in MDL-57742.

      We need to investigate whether this was the right approach.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                markn Mark Nelson
                Participants:
                Component watchers:
                Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: