Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62893

mod: Grade visibility bug in the Outline/Complete reports

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      1. Create a course. Under the Appearance category, set Yes to “Show activity reports”.
      2. Set the default theme to Clean (because the testing instructions have been prepared using it).
      mod_assign
      1. Add an assignment.
      2. As a student, make a submission.
      3. Login as the student:
        1. Go to the course.
        2. In the Navigation block - under the Courses node - select Participants - then the student’s account name.
        3. In the Reports block - select “Outline report”.
        4. CHECK the entry for the activity is shown and no warning is displayed.
      4. As a teacher, grade the assignment.
      5. In the Course administration block, click “Gradebook setup“.
      6. Hide the grade.
      7. Login as the student:
        1. Go to the course.
        2. In the Navigation block - under the Courses node - select Participants - then the student’s account name.
        3. In the Reports block - select “Outline report”.
        4. CHECK the grade is hidden.
      mod_data
      1. Add a Database activity.
      2. Enable grading on the database: whilst editing the database - go the Ratings category and select an "Aggregate type".
      3. Add a field for the activity (it doesn't matter its type).
      4. Save the template.
      5. Login as a student.
      6. Add an entry.
      7. Repeat step 3 in the mod_assign instructions.
      8. Login as a teacher.
      9. Go to the “View single” page - then rate the topic.
      10. In the Course administration block, click “Gradebook setup“.
      11. Hide the grade.
      12. Repeat steps 6 and beyond in the mod_assign instructions.
      13. Login as the student:
        1. Go to the course.
        2. In the Navigation block - under the Courses node - select Participants - then the student’s account name.
        3. In the Reports block - select “Complete report”.
        4. CHECK the grade is hidden.
      mod_forum
      1. Add a Forum activity.
      2. Enable grading on the forum: Whilst editing the forum - go the Ratings category and select an "Aggregate type".
      3. Login as a student.
      4. Add a discussion topic to the forum.
      5. Repeat step 3 in the mod_assign instructions.
      6. Login as a teacher.
      7. Rate the new topic.
      8. In the Course administration block, click “Gradebook setup“.
      9. Hide the grade.
      10. Repeat steps 6 and beyond in the mod_assign instructions.
      11. Repeat steps 12 and beyond in the mod_data instructions.
      mod_glossary
      1. Add a Glossary activity.
      2. Enable grading: Whilst editing the glossary - go the Ratings category and select an Aggregate type.
      3. Login as a student.
      4. Add an entry.
      5. Repeat step 3 in the mod_assign instructions.
      6. Login as a teacher.
      7. Rate the entry.
      8. In the Course administration block, click “Gradebook setup“.
      9. Hide the grade.
      10. Repeat steps 6 and beyond in the mod_assign instructions.
      11. Repeat steps 12 and beyond in the mod_data instructions.
      mod_lesson
      1. Add a Lesson activity.
      2. Add a question page.
      3. Login as a student.
      4. Complete the question page.
      5. Repeat step 3 in the mod_assign instructions.
      6. Login as a teacher
      7. In the Course administration block, click “Gradebook setup“.
      8. Hide the grade.
      9. Repeat steps 6 and beyond in the mod_assign instructions.
      10. Repeat steps 12 and beyond in the mod_data instructions.
      mod_scorm
      1. Add a Scorm activity.
      2. Login as a student
      3. Complete the Scorm activity.
      4. Repeat step 3 in the mod_assign instructions.
      5. Login as a teacher
      6. In the Course administration block, click “Gradebook setup“.
      7. Hide the grade.
      8. Repeat steps 6 and beyond in the mod_assign instructions.
      9. Repeat steps 12 and beyond in the mod_data instructions.
      mod_workshop
      1. Add a Workshop activity. 
      2. Configure the activity.
      3. Switch to the Submission phase.
      4. Login as a student
      5. Make a submission.
      6. Repeat step 3 in the mod_assign instructions.
      7. Login as a teacher
      8. At the Grading evaluation phase - grade the submission.
      9. In the Course administration block, click “Gradebook setup“.
      10. Hide the grade.
      11. Repeat steps 6 and beyond in the mod_assign instructions.
      12. Repeat steps 12 and beyond in the mod_data instructions.
      Show
      Setup Create a course. Under the Appearance category, set Yes to “Show activity reports”. Set the default theme to Clean (because the testing instructions have been prepared using it). mod_assign Add an assignment. As a student, make a submission. Login as the student: Go to the course. In the Navigation block - under the Courses node - select Participants - then the student’s account name. In the Reports block - select “Outline report”. CHECK  the entry for the activity is shown and no warning is displayed. As a teacher, grade the assignment. In the Course administration block, click “Gradebook setup“. Hide the grade. Login as the student: Go to the course. In the Navigation block - under the Courses node - select Participants - then the student’s account name. In the Reports block - select “Outline report”. CHECK the grade is hidden. mod_data Add a Database activity. Enable grading on the database: whilst editing the database - go the Ratings category and select an "Aggregate type". Add a field for the activity (it doesn't matter its type). Save the template. Login as a student. Add an entry. Repeat step 3 in the mod_assign instructions. Login as a teacher. Go to the “View single” page - then rate the topic. In the Course administration block, click “Gradebook setup“. Hide the grade. Repeat steps 6 and beyond in the mod_assign instructions. Login as the student: Go to the course. In the Navigation block - under the Courses node - select Participants - then the student’s account name. In the Reports block - select “Complete report”. CHECK  the grade is hidden. mod_forum Add a Forum activity. Enable grading on the forum: Whilst editing the forum - go the Ratings category and select an "Aggregate type". Login as a student. Add a discussion topic to the forum. Repeat step 3 in the mod_assign instructions. Login as a teacher. Rate the new topic. In the Course administration block, click “Gradebook setup“. Hide the grade. Repeat steps 6 and beyond in the mod_assign instructions. Repeat steps 12 and beyond in the mod_data instructions. mod_glossary Add a Glossary activity. Enable grading: Whilst editing the glossary - go the Ratings category and select an Aggregate type. Login as a student. Add an entry. Repeat step 3 in the mod_assign instructions. Login as a teacher. Rate the entry. In the Course administration block, click “Gradebook setup“. Hide the grade. Repeat steps 6 and beyond in the mod_assign instructions. Repeat steps 12 and beyond in the mod_data instructions. mod_lesson Add a Lesson activity. Add a question page. Login as a student. Complete the question page. Repeat step 3 in the mod_assign instructions. Login as a teacher In the Course administration block, click “Gradebook setup“. Hide the grade. Repeat steps 6 and beyond in the mod_assign instructions. Repeat steps 12 and beyond in the mod_data instructions. mod_scorm Add a Scorm activity. Login as a student Complete the Scorm activity. Repeat step 3 in the mod_assign instructions. Login as a teacher In the Course administration block, click “Gradebook setup“. Hide the grade. Repeat steps 6 and beyond in the mod_assign instructions. Repeat steps 12 and beyond in the mod_data instructions. mod_workshop Add a Workshop activity.  Configure the activity. Switch to the Submission phase. Login as a student Make a submission. Repeat step 3 in the mod_assign instructions. Login as a teacher At the Grading evaluation phase - grade the submission. In the Course administration block, click “Gradebook setup“. Hide the grade. Repeat steps 6 and beyond in the mod_assign instructions. Repeat steps 12 and beyond in the mod_data instructions.
    • Affected Branches:
      MOODLE_31_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-62893_master

      Description

      Hi,

      One of our clients has come across a bug. I’ve provided a patch.

      Grades that have been hidden will appear in the outline and complete reports - even if the user is a student.

        Attachments

        1. Complete report.png
          Complete report.png
          33 kB
        2. Hide grade.png
          Hide grade.png
          55 kB
        3. MDL-62893.jpg
          MDL-62893.jpg
          68 kB
        4. MDL-62893 (2).jpg
          MDL-62893 (2).jpg
          44 kB
        5. Outline complete reports link.png
          Outline complete reports link.png
          73 kB
        6. Outline report.png
          Outline report.png
          43 kB
        7. Show activity reports.png
          Show activity reports.png
          28 kB

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/19

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 30 minutes
                3h 30m