Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62896

Plugin data registry page - some non-core plugins are missing their Additional label

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Add an external plugin with _ as part of its own shortname, e.g. block_course_overview, https://moodle.org/plugins/block_course_overview
      3. Go to "Site administration / Users / Privacy and policies / Plugin privacy registry"
      4. Click "Expand all"
      5. Search for the "Course overview (legacy)" block.
      6. Confirm that it shows an "Additional" label beside its name.
      Show
      Log in as admin Add an external plugin with _ as part of its own shortname, e.g. block_course_overview, https://moodle.org/plugins/block_course_overview Go to " Site administration / Users / Privacy and policies / Plugin privacy registry " Click " Expand all " Search for the " Course overview (legacy) " block. Confirm that it shows an "Additional" label beside its name.
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Epic Link:
    • Pull Master Branch:
      MDL-62896-master
    • Sprint:
      GDPR Followup Sprint 1

      Description

      Plugin data registry page - some non-core plugins are missing their Additional label

      Noticed this while adding some external plugins and adding GDPR privacy code, and went looking to see why...

      The reason is that external plugin names are not excluded from containing _ characters, so the explode strip to find the plugin shortname needs to be limited to 2, to just remove the initial plugintype, and allow the pluginname to match the relevant search.

        Attachments

          Activity

            People

            Assignee:
            wuzi1999 Karen Holland
            Reporter:
            wuzi1999 Karen Holland
            Peer reviewer:
            Jun Pataleta Jun Pataleta
            Integrator:
            Andrew Lyons Andrew Lyons
            Tester:
            Anna Carissa Sadia Anna Carissa Sadia
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Sep/18

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 30 minutes
                1h 30m