[MDL-62896] Plugin data registry page - some non-core plugins are missing their Additional label - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5, 3.5.1
Fix Version/s: 3.3.8, 3.4.5, 3.5.2
Component/s: Privacy
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_35_STABLE
Fixed Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
Epic Link:
GDPR Followups
Pull from Repository:
git://github.com/k-holland/moodle.git
Pull Master Branch:
~~MDL-62896~~-master
Pull Master Diff URL:
https://github.com/k-holland/moodle/compare/6e020b161a...MDL-62896-master
Testing Instructions:
Hide

Log in as admin

Add an external plugin with _ as part of its own shortname, e.g. block_course_overview, https://moodle.org/plugins/block_course_overview

Go to "Site administration / Users / Privacy and policies / Plugin privacy registry"

Click "Expand all"

Search for the "Course overview (legacy)" block.

Confirm that it shows an "Additional" label beside its name.
Show
Log in as admin Add an external plugin with _ as part of its own shortname, e.g. block_course_overview, https://moodle.org/plugins/block_course_overview Go to " Site administration / Users / Privacy and policies / Plugin privacy registry " Click " Expand all " Search for the " Course overview (legacy) " block. Confirm that it shows an "Additional" label beside its name.

Sprint:
GDPR Followup Sprint 1

Description

Plugin data registry page - some non-core plugins are missing their Additional label

Noticed this while adding some external plugins and adding GDPR privacy code, and went looking to see why...

The reason is that external plugin names are not excluded from containing _ characters, so the explode strip to find the plugin shortname needs to be limited to 2, to just remove the initial plugintype, and allow the pluginname to match the relevant search.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-62896.PNG
30 kB
15/Aug/18 6:26 PM
MDL-62896-travis-build.png
45 kB
13/Jul/18 5:43 AM

Activity

People

Assignee:: Karen Holland

Reporter:: Karen Holland

Peer reviewer:: Jun Pataleta

Integrator:: Andrew Lyons

Tester:: Anna Carissa Sadia

Participants:: Adrian Greeve, Andrew Lyons, Anna Carissa Sadia, CiBoT, Eloy Lafuente (stronk7), Jun Pataleta, Karen Holland

Component watchers:: Andrew Lyons, Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 11/Jul/18 8:22 AM

Updated:: 28/Sep/18 9:53 AM

Resolved:: 18/Aug/18 11:40 AM

Fix Release Date:: 10/Sep/18

Time Tracking

Estimated:

Remaining:

Logged:

1h 30m