Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62914

Ical import crashes when TZURL property present (lib/bennu)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.7, 3.4.4, 3.5.1, 3.6
    • Fix Version/s: 3.4.5, 3.5.2
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide
      • On front page, click "Go to calendar"
      • Click "Manage subscriptions"
      • Enter a calendar name, and select "Import from - Calendar file (.ics)"
      • Upload the .ics test file (attached)
      • Click "Add"
      • VERIFY: Message reads "Events imported: 1"

      (Behaviour without the patch: an exception message is displayed.)

      Show
      On front page, click "Go to calendar" Click "Manage subscriptions" Enter a calendar name, and select "Import from - Calendar file (.ics)" Upload the .ics test file (attached) Click "Add" VERIFY: Message reads "Events imported: 1" (Behaviour without the patch: an exception message is displayed.)
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-62914-master

      Description

      When importing an ical file (or feed) into the calendar, if the ical file uses the TZURL property (see here), the import routine stops with an exception.

      This is due to an error in lib/bennu where the corresponding property class is not defined.

      I attach a file with which this error occurs.

      The problem seems to affect all versions from master back to 3.3 (and probably much earlier).

      Patch to follow shortly.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Sep/18