Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62919

Unused setting auth_shibboleth | auth_instructions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.4, 3.5
    • Fix Version/s: 3.4.5, 3.5.2
    • Component/s: Authentication
    • Labels:
    • Testing Instructions:
      Hide

      Setup

      1. Login as an admin.
      2. Go to "Site administration / Plugins / Authentication / Manage authentication" and enable Shibboleth.
      3. Edit Shibboleth settings and update hte "Login instructions" (auth_instructions) setting to something like

        <h4 class="p-1 bg-success">LOGIN INSTRUCTIONS HERE!</h4>
        

        Important: we aren’t testing a Shibboleth connection. We are testing if index_form.html shows shibboleth/auth_instructions

      Case 1

      1. Login as an admin.
      2. Go to "Site administration / Plugins / Authentication / Manage authentication"  and enable Email-based self-registration method.
      3. Also, enable "Self registration" and select "Email-based self-registration" option.
      4. Open a new browser window (e.g. incognito)
      5. On the other browser window, go to "/auth/shibboleth/login.php" of your Moodle site.
      6. Confirm that you can see the login instructions text "LOGIN INSTRUCTIONS HERE!" (highlighted in green) in between the "Is your first time here?" header and the "Create new account" button

      Case 2

      1. Back to the first window (admin view), disable the "Email-based registration" authentication plugin
      2. Refresh the second browser window
      3. Confirm that you can see the login instructions text "LOGIN INSTRUCTIONS HERE!" (highlighted in green) below the "Is your first time here?" header

      Case 3

      1. You need a new option on the Self registration selector. To do that, you need to edit config.php and add this value: $CFG->registerauth = 'shibboleth';
      2. Refresh the second window
      3. Expected result: Check you can see below Is your first time here? the text you have added before in auth_instructions.
      Show
      Setup Login as an admin. Go to "Site administration / Plugins / Authentication / Manage authentication" and enable Shibboleth. Edit Shibboleth settings and update hte " Login instructions " (auth_instructions) setting to something like <h4 class="p-1 bg-success">LOGIN INSTRUCTIONS HERE!</h4> Important:  we aren’t testing a Shibboleth connection. We are testing if index_form.html shows shibboleth/auth_instructions Case 1 Login as an admin. Go to "Site administration / Plugins / Authentication / Manage authentication"   and enable Email-based self-registration method. Also, enable " Self registration " and select " Email-based self-registration " option. Open a new browser window (e.g. incognito) On the other browser window, go to " /auth/shibboleth/login.php " of your Moodle site. Confirm that you can see the login instructions text " LOGIN INSTRUCTIONS HERE! " (highlighted in green) in between the " Is your first time here? " header and the " Create new account " button Case 2 Back to the first window (admin view), disable the " Email-based registration " authentication plugin Refresh the second browser window Confirm that you can see the login instructions text " LOGIN INSTRUCTIONS HERE! " (highlighted in green) below the " Is your first time here? " header Case 3 You need a new option on the Self registration selector. To do that, you need to edit config.php and add this value: $CFG->registerauth = 'shibboleth'; Refresh the second window Expected result: Check you can see below Is your first time here? the text you have added before in auth_instructions.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-62919-master

      Description

      This setting is not used anywhere. The only one used in core is $CFG->auth_instructions. We should either remove it or change index_form.html so that it uses it.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h