Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62968

TinyMCE Class menu on Insert/Edit Image settings incomplete or missing under Boost

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup
      We need to start this test with the following enabled: Boost theme, TinyMCE text editor, theme designer mode on (theme cache disabled). This is done as follows:

      1. Log into your test Moodle site as admin.
      2. Navigate to Site administration > Plugins, under the Text editors section, click 'Manage editors'.
      3. If the 'TinyMCE HTML editor' is disabled, click the crossed out eye symbol to enable it.
      4. If 'TinyMCE HTML editor' is not at the top of the list of editors, click the up arrow in its row until it is at the top of the list.
      5. Navigate to Site administration > Appearance > Theme settings.
      6. Turn on 'Theme designer mode' by checking the relevant checkbox, and clicking save changes.
      7. Navigate to Site administration > Appearance > Theme selector.
      8. Click 'Clear theme caches'.
      9. When the page reloads, check the current theme is set to Boost. If it is not, click 'Change theme' and change it to Boost.

      Testing Boost is now fixed

      1. Log into your test Moodle site as admin.
      2. Navigate to the user's profile (user dropdown at top right of the window > Profile).
      3. Click 'Edit profile'.
      4. Scroll down to the Description and CONFIRM you see the TinyMCE text editor:
      5. Type some text into the text area of Description and CONFIRM the text is a reasonable size (not smaller than the text that says 'Description' to the left of the editor), eg:
      6. Click the 'Insert/edit image' button on the top row of the TinyMCE editor:
      7. Click the 'Appearance' tab.
      8. CONFIRM there is a dropdown menu available for 'Class', and CONFIRM when you click the dropdown, there is a long list of classes, eg:
         
      1. Navigate to Site administration > Appearance > Theme settings (you may want to do this in a new tab, so it is easier to return to the 'Edit profile' screen shortly).
      2. Disable 'Theme designer mode' by unchecking the relevant checkbox, and clicking Save changes.
      3. Navigate back to your user's 'Edit profile' screen and click 'Purge all caches' at the very bottom of the page. If you don't see that (debug mode is not enabled in your Moodle site), do a hard browser refresh (eg ctrl+F5 or command+shift+r depending on your operating system).
      4. Repeat steps 5-8 above and CONFIRM the relevant steps are still working.

      Testing Clean is still working as expected

      1. Switch your site to 'Clean' theme, clear all caches, then repeat steps 5-8 above again on the 'Edit profile' page. (This will mean you are testing on Clean with designer mode disabled). CONFIRM all relevant steps as before.
      2. Turn 'Theme designer mode' back on as you did in the setup steps above, then repeat steps 5-8 above again on the 'Edit profile' page (this will mean you are testing on Clean with designer mode enabled). CONFIRM all relevant steps as before.
      Show
      Setup We need to start this test with the following enabled: Boost theme, TinyMCE text editor, theme designer mode on (theme cache disabled). This is done as follows: Log into your test Moodle site as admin. Navigate to Site administration > Plugins, under the Text editors section, click 'Manage editors'. If the 'TinyMCE HTML editor' is disabled, click the crossed out eye symbol to enable it. If 'TinyMCE HTML editor' is not at the top of the list of editors, click the up arrow in its row until it is at the top of the list. Navigate to Site administration > Appearance > Theme settings. Turn on 'Theme designer mode' by checking the relevant checkbox, and clicking save changes. Navigate to Site administration > Appearance > Theme selector. Click 'Clear theme caches'. When the page reloads, check the current theme is set to Boost. If it is not, click 'Change theme' and change it to Boost. Testing Boost is now fixed Log into your test Moodle site as admin. Navigate to the user's profile (user dropdown at top right of the window > Profile). Click 'Edit profile'. Scroll down to the Description and CONFIRM you see the TinyMCE text editor: Type some text into the text area of Description and CONFIRM the text is a reasonable size (not smaller than the text that says 'Description' to the left of the editor), eg: Click the 'Insert/edit image' button on the top row of the TinyMCE editor: Click the 'Appearance' tab. CONFIRM there is a dropdown menu available for 'Class', and CONFIRM when you click the dropdown, there is a long list of classes, eg:   Navigate to Site administration > Appearance > Theme settings (you may want to do this in a new tab, so it is easier to return to the 'Edit profile' screen shortly). Disable 'Theme designer mode' by unchecking the relevant checkbox, and clicking Save changes. Navigate back to your user's 'Edit profile' screen and click 'Purge all caches' at the very bottom of the page. If you don't see that (debug mode is not enabled in your Moodle site), do a hard browser refresh (eg ctrl+F5 or command+shift+r depending on your operating system). Repeat steps 5-8 above and CONFIRM the relevant steps are still working. Testing Clean is still working as expected Switch your site to 'Clean' theme, clear all caches, then repeat steps 5-8 above again on the 'Edit profile' page. (This will mean you are testing on Clean with designer mode disabled). CONFIRM all relevant steps as before. Turn 'Theme designer mode' back on as you did in the setup steps above, then repeat steps 5-8 above again on the 'Edit profile' page (this will mean you are testing on Clean with designer mode enabled). CONFIRM all relevant steps as before.
    • Affected Branches:
      MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-62968-master

      Description

      When using TinyMCE using Boost, the "Class" menu that is present on the Insert/Edit Image Appearance pane is missing any selectable classes. It also appears this way in other TinyMCE panes (e.g., Insert/Edit Table).  Using the Clean theme, the selectable classes are present. 

      The screenshots added are from the current Moodle 3.5.1 server at demo.moodle.net.

        Attachments

        1. tinymce clean 3.5 - image.png
          tinymce clean 3.5 - image.png
          84 kB
        2. tinymce boost 3.5 demo - image.png
          tinymce boost 3.5 demo - image.png
          54 kB
        3. tinyMCE.png
          tinyMCE.png
          4 kB
        4. MDL-62968-fixed.png
          MDL-62968-fixed.png
          44 kB
        5. MDL-62968_Clean.jpg
          MDL-62968_Clean.jpg
          54 kB
        6. MDL-62968_Boost.jpg
          MDL-62968_Boost.jpg
          42 kB
        7. MDL-60588-fixed.png
          MDL-60588-fixed.png
          17 kB
        8. inserteditimage.png
          inserteditimage.png
          0.6 kB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Mar/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour
                  1h