Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62973

Improve auth_shibboleth's login form

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.4
    • Fix Version/s: 3.7
    • Component/s: Authentication
    • Labels:
    • Testing Instructions:
      Hide

      Note: Test on Boost and Clean

      Setup
      1. Log in as an admin
      2. Go to Site administration / Plugins / Authentication / Manage authentication
      3. Turn the Shibboleth authentication plugin on.
      4. Open another Moodle instance that doesn't have this patch on (e.g. a Moodle 3.6 instance) and do the same setup. Let's call this MOODLE2.
      Test
      1. Under Common settings, set Self-registration to "Email-based self-registration".
      2. Make sure that Guest login button is also set to "Show"
      3. Save the changes.
      4. Open an incognito browser window.
      5. Enter on your browser's address bar: http://[YOUR_MOODLE_URL]/auth/shibboleth/login.php
      6. Check the appearance of the page.
      7. Confirm that it looks way nicer and consistent with the current theme compared to the original version (e.g. on your MOODLE2 instance).
      8. Confirm the layout looks good. On Clean, the guest login section will stack underneath, this is fine.
      9. Hover on the "Moodle Administrator" link.
      10. Confirm that it points to "mailto:[ADMIN'S EMAIL ADDRESS]"
      11. Hover on the "Shibboleth login" link.
      12. Confirm that it points to "[YOUR_MOODLE_URL]/auth/shibboleth/index.php"
      13. Click on "Log in as a guest"
      14. Confirm that you get logged in as a guest.
      15. Go back to the Shibboleth login page.
      16. Click on "Create new account"
      17. Confirm that you are redirected to the self-registration page.
      18. Go back to the Shibboleth login page.
      19. Back on the admin's browser window, disable "Self-registration".
      20. Set the "Guest login button" also to "Hide"
      21. Set the and save the changes.
      22. Back on the incognito browser window, refresh the Shibboleth login page.
      23. Confirm that the "Create new account" button is no longer shown.
      24. Confirm that the guest log in section is also no longer shown.
      25. Without selecting anything, click on "Select"
      26. Confirm that you get a validation error "Please select the organization you are member of!"
      27. Select "Example Organization 1"
      28. Click "Select"
      29. You'll get redirected to a page with an error. But this is okay. You need to take note of the URL of that page.
      30. On another incognito browser tab, open your MOODLE2 instance and go to the Shibboleth login form and perform the previous 3 steps.
      31. Compare the URL from the moodle instance you're testing and the URL from the MOODLE2 instance.
      32. Confirm that aside from the difference in the URLs in the "target" parameters (since they point to the Moodle instance you're testing and on MOODLE2's URL), they are basically the same.
      33. Repeat the above tests for the other 2 test options in the select box.
      Show
      Note: Test on Boost and Clean Setup Log in as an admin Go to Site administration / Plugins / Authentication / Manage authentication Turn the Shibboleth authentication plugin on. Open another Moodle instance that doesn't have this patch on (e.g. a Moodle 3.6 instance) and do the same setup. Let's call this MOODLE2. Test Under Common settings, set Self-registration to " Email-based self-registration ". Make sure that Guest login button is also set to " Show " Save the changes. Open an incognito browser window. Enter on your browser's address bar: http://[YOUR_MOODLE_URL]/auth/shibboleth/login.php Check the appearance of the page. Confirm that it looks way nicer and consistent with the current theme compared to the original version (e.g. on your MOODLE2 instance). Confirm the layout looks good. On Clean, the guest login section will stack underneath, this is fine. Hover on the " Moodle Administrator " link. Confirm that it points to "mailto:[ADMIN'S  EMAIL ADDRESS] " Hover on the " Shibboleth login " link. Confirm that it points to " [YOUR_MOODLE_URL] /auth/shibboleth/index.php" Click on " Log in as a guest " Confirm that you get logged in as a guest. Go back to the Shibboleth login page. Click on " Create new account " Confirm that you are redirected to the self-registration page. Go back to the Shibboleth login page. Back on the admin's browser window, disable " Self-registration ". Set the " Guest login button " also to " Hide " Set the and save the changes. Back on the incognito browser window, refresh the Shibboleth login page. Confirm that the " Create new account " button is no longer shown. Confirm that the guest log in section is also no longer shown. Without selecting anything, click on " Select " Confirm that you get a validation error " Please select the organization you are member of! " Select " Example Organization 1 " Click " Select " You'll get redirected to a page with an error. But this is okay. You need to take note of the URL of that page. On another incognito browser tab, open your MOODLE2 instance and go to the Shibboleth login form and perform the previous 3 steps. Compare the URL from the moodle instance you're testing and the URL from the MOODLE2 instance. Confirm that aside from the difference in the URLs in the " target " parameters (since they point to the Moodle instance you're testing and on MOODLE2's URL), they are basically the same. Repeat the above tests for the other 2 test options in the select box.
    • Affected Branches:
      MOODLE_34_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull Master Branch:
      MDL-62973-master

      Description

      It's 2018 already and auth_shibboleth's login form needs some Moodle love, especially auth/shibboleth/index_form.php.

        Attachments

        1. 1.PNG
          1.PNG
          350 kB
        2. 2.PNG
          2.PNG
          156 kB
        3. 3.PNG
          3.PNG
          254 kB
        4. 4.PNG
          4.PNG
          193 kB
        5. after-boost.png
          after-boost.png
          61 kB
        6. after-clean.png
          after-clean.png
          55 kB
        7. before.png
          before.png
          53 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 52 minutes
                  52m