Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62992

Hide question tag filter when tags disabled.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      PLEASE TEST ON BOTH BOOST AND CLEAN THEMES, AND FOR MASTER, ALSO CLASSIC THEME

      Question bank tag filtering test.

      1. Log in as admin.
      2. Go to any course, click on the cog and go to More...
      3. Go to question bank.
      4. Add few questions or use existing ones, add a tag to each question.
        • Please note, don't forget to hit enter to add the tag to the question.
      5. In a separated tab, go to Site administration > Advanced features and disable usetags setting.
      6. In the other tab, reload the question bank page.
      7. Make sure tags icon is not displayed for the questions.
      Quiz tag filtering test.
      1. Now create or use an existing quiz.
      2. Edit quiz and click Add > From question bank
      3. Make sure tags filter is not displayed
      4. Close the modal and now click Add > a random question
      5. Make sure tags filter is not displayed
      6. Now in that other tab, enable usetags setting again.
      7. In the other tab, Edit quiz and click Add > From question bank
      8. Make sure tags filter is displayed
      9. Filter the questions by the tags you have added previously.
      10. * Make sure the filter works as expected*
      11. Close the modal and now click Add > a random question
      12. Make sure the filter works as expected
      13. Filter by the tags you have added previously.
      Show
      PLEASE TEST ON BOTH BOOST AND CLEAN THEMES, AND FOR MASTER, ALSO CLASSIC THEME Question bank tag filtering test. Log in as admin. Go to any course, click on the cog and go to More... Go to question bank. Add few questions or use existing ones, add a tag to each question. Please note, don't forget to hit enter to add the tag to the question. In a separated tab, go to Site administration > Advanced features and disable usetags setting. In the other tab, reload the question bank page. Make sure tags icon is not displayed for the questions. Quiz tag filtering test. Now create or use an existing quiz. Edit quiz and click Add > From question bank Make sure tags filter is not displayed Close the modal and now click Add > a random question Make sure tags filter is not displayed Now in that other tab, enable usetags setting again. In the other tab, Edit quiz and click Add > From question bank Make sure tags filter is displayed Filter the questions by the tags you have added previously. * Make sure the filter works as expected* Close the modal and now click Add > a random question Make sure the filter works as expected Filter by the tags you have added previously.
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull 3.6 Branch:
    • Pull Master Branch:
      MDL-62992-master

      Description

      Uncheck enable tags functionality in Advanced features settings. Go to question bank, Filter by tags box still appears, but does not do anything. This is potentially confusing on sites where tags are not used.

      On the quiz editing form open add random question. The tag the search blank also appears here when it should not with tags disabled.

        Attachments

        1. 1.png
          1.png
          119 kB
        2. 2.png
          2.png
          144 kB
        3. 3.png
          3.png
          147 kB
        4. 4.png
          4.png
          164 kB

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/May/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 30 minutes
                2h 30m