Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63002

Fix incorrect calls to non-existent delete_record() function

XMLWordPrintable

    • MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • MOODLE_34_STABLE, MOODLE_35_STABLE
    • MDL-63002_master
    • Hide
      Test 1

      (to be verified in 35_STABLE and master)

      1. Create a course.
      2. Visit the course.
      3. Click on 'Grades' in the course.
      4. Click on the tab 'Letters'.
      5. Click on 'Edit grade letters'.
      6. Check 'Override site defaults'.
      7. Save changes.
      8. Click on 'Edit grade letters'.
      9. Uncheck 'Override site defaults'.
      10. Save changes.
      11. Ensure you did not experience an exception.
      Test 2

      (to be verified in 34_STABLE, 35_STABLE and master)

      1. Create a course.
      2. Add a lesson module.
      3. Click 'Add a cluster'.
      4. Visit the database table 'lesson_answers' using whatever tool you prefer.
      5. Duplicate the row that was added.
      6. Back on the Edit page of the lesson module in Moodle, click on the 'cog' icon on the "Actions" column
      7. Click 'Save page'.
      8. Ensure you did not experience an exception.
      Test 3

      Everything else is covered by unit tests.

      Show
      Test 1 (to be verified in 35_STABLE and master) Create a course. Visit the course. Click on 'Grades' in the course. Click on the tab 'Letters'. Click on 'Edit grade letters'. Check 'Override site defaults'. Save changes. Click on 'Edit grade letters'. Uncheck 'Override site defaults'. Save changes. Ensure you did not experience an exception. Test 2 (to be verified in 34_STABLE, 35_STABLE and master) Create a course. Add a lesson module. Click 'Add a cluster'. Visit the database table 'lesson_answers' using whatever tool you prefer. Duplicate the row that was added. Back on the Edit page of the lesson module in Moodle, click on the 'cog' icon on the " Actions " column Click 'Save page'. Ensure you did not experience an exception. Test 3 Everything else is covered by unit tests.

      Solved the -MDL-45837- Tracker an error has crept in. It's a small mistake with a big effect.

      Step-by-step instructions

      1. Go to a course and select "Grades"
      2. In the Grader report choose tab "Letters"
      3. Edit the grade letters, check "Override site defaults" and Save changes.
      4. After reverting these changes by unchecking "Override site defaults" and Save changes leads to an exception.

      Expected result

      The custom grade letters should be deleted and set to defaults.

      Actual result

      The custom note letters can't be deleted and an coding exception is thrown.

      Error message

      PS: Reproduced on demo.moodle.net

        1. image-2018-08-01-14-26-08-491.png
          image-2018-08-01-14-26-08-491.png
          103 kB
        2. MDL-63002.PNG
          MDL-63002.PNG
          10 kB

            markn Mark Nelson
            pead Adrian Perez
            Mark Nelson Mark Nelson
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Janelle Barcega Janelle Barcega
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 30 minutes
                1h 30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.