Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63012

Grunt Node check always reports version too low

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.3.7, 3.4.4, 3.5.1, 3.6
    • Fix Version/s: 3.6
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      1. Install a version of Node which does not meet the criteria.
      2. Install Node modules / global grunt-cli in order to run the Moodle Grunt tasks.
      3. Run a task e.g. grunt ignorefiles
      4. CONFIRM that the error message displayed includes "Node version not satisfied" and not "Node version too low"
      Show
      Install a version of Node which does not meet the criteria. Install Node modules / global grunt-cli in order to run the Moodle Grunt tasks. Run a task e.g. grunt ignorefiles CONFIRM that the error message displayed includes "Node version not satisfied" and not "Node version too low"
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-63012-master

      Description

      Before running a given task the Grunt runner checks that the installed Node is the Carbon LTS greater than 8.9.0 (see also MDL-61893). When this requirement is not satisfied Grunt exits with an error message which states "Node version too old" even if the failure was triggered by a newer Node version (screenshot attached). The rest of the message correctly describes the version requirement. Nothing is broken at worst this could be a little confusing.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/18