Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63028

Use flexbox for positioning the Boost footer

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5
    • Fix Version/s: 3.6
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Please test this on all supported browsers, see https://docs.moodle.org/dev/Moodle_3.5_release_notes#Browser_support

      This is a change for theme boost only

      Test a page without blocks

      1. Log in as Admin
      2. Use a large monitor and use the full screen for your browser or use your browser controls to zoom out.
      3. Browse to the "My Private files" page
      4. Resize your browser or zoom out so everything fits within the viewport, verify you do not need to scroll to see the footer.

      Test a page with blocks

      1. Browse to a course with blocks
      2. Resize your browser and verify the footer is fully visible without having to scroll until there is not enough space and the entire page scrolls.

      Test a secured page

      1. Create a new quiz
      2. On the quiz editing form scroll down to "Extra restrictions on attempts", click the show more link and select "Full screen popup with some Javascript security"
      3. Save the form an add a question of any type
      4. Attempt the quiz
      5. Resize your browser or zoom out so everything fits within the viewport, verify you do not need to scroll to see the footer. Note: This footer is expected to be just a single strip, with no contents.

      Test a maintenance page

      1. Log in as Admin
      2. Purge caches
      3. Edit main version.php and increase $version by .01
      4. Go to /admin/index.php in your site and upgrade should begin.
      5. Verify that the pages shown in the upgrade process (plugins, environment, upgrade process...) display the footer properly and the page content doesn't overlaps with it.

      Installation

      1. Install moodle via web, from scratch, without config.php so the complete installer will be executed.
      2. Verify in all the install pages, both the "pre-installer" ones (those in charge of creating the config.php file, and the installation ones (environment, site settings, admin user creation...) that the footer is displayed properly, after the content and the content never overlaps it.
      Show
      Please test this on all supported browsers, see  https://docs.moodle.org/dev/Moodle_3.5_release_notes#Browser_support This is a change for theme boost only Test a page without blocks Log in as Admin Use a large monitor and use the full screen for your browser or use your browser controls to zoom out. Browse to the "My Private files" page Resize your browser or zoom out so everything fits within the viewport, verify you do not need to scroll to see the footer. Test a page with blocks Browse to a course with blocks Resize your browser and verify the footer is fully visible without having to scroll until there is not enough space and the entire page scrolls. Test a secured page Create a new quiz On the quiz editing form scroll down to "Extra restrictions on attempts", click the show more link and select "Full screen popup with some Javascript security" Save the form an add a question of any type Attempt the quiz Resize your browser or zoom out so everything fits within the viewport, verify you do not need to scroll to see the footer. Note: This footer is expected to be just a single strip, with no contents. Test a maintenance page Log in as Admin Purge caches Edit main version.php and increase $version by .01 Go to /admin/index.php in your site and upgrade should begin. Verify that the pages shown in the upgrade process (plugins, environment, upgrade process...) display the footer properly and the page content doesn't overlaps with it. Installation Install moodle via web, from scratch, without config.php so the complete installer will be executed. Verify in all the install pages, both the "pre-installer" ones (those in charge of creating the config.php file, and the installation ones (environment, site settings, admin user creation...) that the footer is displayed properly, after the content and the content never overlaps it.
    • Affected Branches:
      MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-63028-master

      Description

      Using flex utilities allows better positioning of the page-content and footer.

      There are a few issues with the current implementation of the sticky footer:

      • If there is enough space you still need to scroll to see the full footer
      • The page content is forced to be 45rems high

       

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/18