Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63074

Rewrite the tool_customlang renderers

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5, 3.7
    • Fix Version/s: 3.7
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      To be tested only with Boost (because MDL-58427 will get rid of old, bootstrapbase, themes for 3.7).

      Tool customlang functionality: changed strings

      1. Login as admin
      2. Navigate to Site Administration -> Language -> Language customisation
      3. Select a language pack and open the language pack for editing
      4. Choose the moodle.php file and click show strings
      5. Change a language string
      6. Save the changes to the language pack
      7. Open the language pack for editing again
      8. Verfiy you see the changed language string
      9. Verify the background colour for the changed language string row has changed.

      Tool customlang functionality: modified strings

      1. Navigate to Site Administration -> Language -> Language customisation
      2. Open the English language pack for editing
      3. Choose the moodle.php file and click show strings
      4. Change string "abouttobeinstalled" to "Bla Bla"
      5. Save changes
      6. edit the file lang/en/moodle.php
      7. Search for $string['abouttobeinstalled'] and change its value to "Test"
      8. Save changes and purge caches
      9. Navigate to Site Administration -> Language -> Language customisation
      10. Open the English language pack for editing
      11. Choose the moodle.php file and click show strings
      12. Verify the string "abouttobeinstalled" shows your original translation "Bla Bla"
      13. Verify the string row for "abouttobeinstalled" has a warning color background.

      Tool customlang: mobile design

      1. Navigate to Site Administration -> Language -> Language customisation
      2. Open the English language pack for editing
      3. Choose the moodle.php file and click show strings
      4. Change your browser size to a tablet size or use a tablet
      5. Verify the design looks similar to:
      6. Change your browser size to a mobile size or use a mobile
      7. Verify the design looks similar to:

       

      Show
      To be tested only with Boost (because MDL-58427 will get rid of old, bootstrapbase, themes for 3.7). Tool customlang functionality: changed strings Login as admin Navigate to Site Administration -> Language -> Language customisation Select a language pack and open the language pack for editing Choose the moodle.php file and click show strings Change a language string Save the changes to the language pack Open the language pack for editing again Verfiy  you see the changed language string Verify  the background colour for the changed language string row has changed. Tool customlang functionality: modified strings Navigate to Site Administration -> Language -> Language customisation Open the English language pack for editing Choose the moodle.php file and click show strings Change string "abouttobeinstalled" to "Bla Bla" Save changes edit the file lang/en/moodle.php Search for $string ['abouttobeinstalled'] and change its value to "Test" Save changes and purge caches Navigate to Site Administration -> Language -> Language customisation Open the English language pack for editing Choose the moodle.php file and click show strings Verify  the string "abouttobeinstalled" shows your original translation "Bla Bla" Verify the string row for "abouttobeinstalled" has a warning color background. Tool customlang: mobile design Navigate to Site Administration -> Language -> Language customisation Open the English language pack for editing Choose the moodle.php file and click show strings Change your browser size to a tablet size or use a tablet Verify the design looks similar to: Change your browser size to a mobile size or use a mobile Verify the design looks similar to:  
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-63074-master

      Description

      The tool_customlang renderers are outdated and the user interface looks bad on Boost.

      Issues to solve are:

      • Make it mobile friendly
      • Fix tooltips
      • Allow more space for the textareas
      • Fix for layout
      • Remove obsolete css

        Attachments

        1. 1.png
          1.png
          78 kB
        2. 2.png
          2.png
          59 kB
        3. phone.png
          phone.png
          155 kB
        4. tablet.png
          tablet.png
          213 kB
        5. tool_customlang.png
          tool_customlang.png
          425 kB

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 8 minutes
                  1h 8m