Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.3.7, 3.4.4, 3.5.1, 3.6
-
Component/s: Privacy
-
Testing Instructions:
-
Affected Branches:MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
-
Fixed Branches:MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
-
Pull from Repository:
-
Pull 3.5 Branch:
MDL-63094-35 -
Pull 3.5 Diff URL:
-
Pull Master Branch:
MDL-63094-master -
Pull Master Diff URL:
Description
I suspect that there are some race conditions with the modals used to display policies from the footer which are causing this:
https://ci.moodle.org/job/S33.05.01%20-%20Behat%20-%20Chrome%20+%20Postgres%20+%20Clean/lastFailedBuild/
The order of the JS is (triggered by clicking on the policy):
- init vars
- make request
- on request success:
- create modal
- setup handler
- display modal
We should re-order this and add in pending checks so that it is:
- init vars
- start pending JS call
- create modal using promises for resolution of body and title
- configure setup of modal
- make request
- on request success resolve promises for body/title
- on display of modal, complete the JS call check