Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63109

User agreements page can't be interacted anymore once the consent modal gets closed

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test in Boost and Clean.

      1. Log in as Admin.
      2. Go to Site administration / Users / Privacy and policies / Policy settings
      3. Set the "Site policy handler to tool_policy.
      4. Save the changes.
      5. Go to Site administration / Users / Privacy and policies / Manage policies
      6. Create a site policy and make it active.
      7. Go to  Site administration / Users / Privacy and policies / User agreements.
      8. Tick one or more users and click on the "Consent" button at the bottom of the table.
      9. When the modal shows up, click "Cancel" or click outside the modal to close it.
      10. Click again on any of the checkboxes.
        • Make sure you can continue selecting/deselecting users.
      11. With some users selected, click on the "Consent" button at the bottom of the table.
      12. When the modal shows up, click "Give consent".
        • Make sure the policies were successfully agreed on behalf of the selected users.
      Show
      Test in Boost and Clean. Log in as Admin. Go to Site administration / Users / Privacy and policies / Policy settings Set the " Site policy handler  to tool_policy. Save the changes. Go to Site administration / Users / Privacy and policies / Manage policies Create a site policy and make it active. Go to  Site administration / Users / Privacy and policies / User agreements. Tick one or more users and click on the " Consent " button at the bottom of the table. When the modal shows up, click " Cancel " or click outside the modal to close it. Click again on any of the checkboxes. Make sure you can continue selecting/deselecting users. With some users selected, click on the " Consent " button at the bottom of the table. When the modal shows up, click "Give consent". Make sure the policies were successfully agreed on behalf of the selected users.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Epic Link:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-63109-master
    • Sprint:
      GDPR Followup Sprint 1

      Description

      To reproduce:

      1. Log in as admin
      2. Go to Site administration / Users / Privacy and policies / Policy settings
      3. Set the "Site policy handler to tool_policy.
      4. Save the changes.
      5. Go to Site administration / Users / Privacy and policies / Manage policies
      6. Create a site policy and make it active.
      7. Back to the "Policies and agreements" page, agreements link for the site policy.
      8. Tick one or more users and click on the "Consent" button at the bottom of the table.
      9. When the modal shows up, click "Cancel" or click outside the modal to close it.
      10. Click again on any of the checkboxes.
      11. Expected: You can continue selecting/deselecting users.
      12. Actual: The page freezes up and you can't do anything anymore unless you refresh the page.

      I thought at first that it could be a regression from MDL-60207. But since I can reproduce this as well even in 35, then the problem is most likely in the "User agreements" page.

        Attachments

        1. MDL-63109_BOOST.PNG
          46 kB
          Anna Carissa Sadia
        2. MDL-63109_CLEAN.PNG
          31 kB
          Anna Carissa Sadia

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 30 minutes
                  30m