Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63125

Single-selection user autocomplete box is confusing to change user

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      1. Log in as an administrator
      2. Create two new users (Fred Smith & Jane Smith)

      Removing item from single select

      Creating a new data request uses a form autocomplete element which only allows for a single selection, so we'll use that to test:

      1. Navigate to Site administration > Users > Privacy and policies > Data requests
      2. Press New request
      3. In the User autocomplete form field search for and select Fred Smith
      4. Press the x button to remove Fred Smith from selection
      5. Confirm No selection is displayed
      6. In the User autocomplete form field search for and select Jane Smith
      7. Press Save changes
      8. Confirm you get a notification informing you "Data request created for Jane Smith"

      Confirm existing multiple select still works

      1. Create a new course
      2. Press Participants
      3. Press Enrol users button
      4. In the Select users field search for "Smith" and select Fred Smith & Jane Smith
      5. Press Enrol selected users and cohorts button
      6. Confirm that both Fred Smith & Jane Smith are now listed in the participants table
      Show
      Setup Log in as an administrator Create two new users ( Fred Smith & Jane Smith ) Removing item from single select Creating a new data request uses a form autocomplete element which only allows for a single selection, so we'll use that to test: Navigate to Site administration > Users > Privacy and policies > Data requests Press New request In the User autocomplete form field search for and select Fred Smith Press the x button to remove Fred Smith from selection Confirm No selection is displayed In the User autocomplete form field search for and select Jane Smith Press Save changes Confirm you get a notification informing you "Data request created for Jane Smith" Confirm existing multiple select still works Create a new course Press Participants Press Enrol users button In the Select users field search for "Smith" and select Fred Smith & Jane Smith Press Enrol selected users and cohorts button Confirm that both Fred Smith & Jane Smith are now listed in the participants table
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE, MOODLE_37_STABLE
    • Pull 3.6 Branch:
    • Pull 3.7 Branch:
    • Pull Master Branch:

      Description

      When you go to a form with a single-selection user autocomplete box, the box starts off blank. If you select a user, but make a mistake, there is no way to remove the user again and go back to blank. (This probably applies to all types of single-select autocomplete box not just users.)

      You can select a different user which then replaces the one you selected before, as Andrew pointed out to me below, so there is not really a functionality problem here. But this wasn't obvious either to our tester who originally complained about this, or to me, so perhaps it would be an improvement to add an X button as in the multi-select forms so users can go back to the blank state.

      Here are steps to get to one of these boxes.

      1. As an administrator or (if configured) DPO account, go to the data requests page (Users / Privacy / Data requests).
      2. Click 'New request'.
      3. Under 'Requesting for', start typing a user's name until a user pops up.
      4. Click on the user to select them.
        • Note there is no X button to remove the user again.

      I attached a screenshot of this from demo.moodle.net.

      I don't have time to fix this one and it's obviously a minor issue, but I filed it because our tester reported it and maybe other people might some day be interested enough to fix it.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/Nov/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 45 minutes
                  5h 45m