Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63171

Edit PDF: Stamps and comments aren't hidden outside the student view's viewport

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.5
    • Fix Version/s: None
    • Component/s: Assignment
    • Testing Instructions:
      Hide

      Setup

      Make sure ghostscript is enabled and working:

      Site administration / ►Plugins / ►Activity modules / ►Assignment / ►Feedback plugins / ►Annotate PDF

      In a course with at least one student and one teacher

      Create an assignment that allows file submissions

      Login as the student and submit a pdf file

      Login as the teacher and go to the "View all submissions" page for the assignment

      On all browsers in both clean and boost themes with a narrow window (500 pixels wide) and a wide window (1200 pixels wide)

      1. Click on the "Grade" button for the submission.
      2. Add a stamp at the right edge and the bottom edge of the submission.
      3. Add a text comment at the right edge and the bottom edge of the submission.
      4. Verify that the stamp, or the text comment will display outside the page boundaries (they should get cut off).
      5. Verify that the other annotation tools do not allow you to add annotations outside the page boundary (e.g. cannot draw a square outside of the page).
      6. Click save and return to the "View all submissions" page.
      7. Click the "View annotated PDF" button
      8. Verify that the submission is displayed with the saved annotations in a modal window that takes up the entire browser window.
      9. Verify that none of the annotations are displayed outside the page boundary. 
      Show
      Setup Make sure ghostscript is enabled and working: Site administration / ►Plugins / ►Activity modules / ►Assignment / ►Feedback plugins / ►Annotate PDF In a course with at least one student and one teacher Create an assignment that allows file submissions Login as the student and submit a pdf file Login as the teacher and go to the "View all submissions" page for the assignment On all browsers in both clean and boost themes with a narrow window (500 pixels wide) and a wide window (1200 pixels wide) Click on the "Grade" button for the submission. Add a stamp at the right edge and the bottom edge of the submission. Add a text comment at the right edge and the bottom edge of the submission. Verify that the stamp, or the text comment will display outside the page boundaries (they should get cut off). Verify that the other annotation tools do not allow you to add annotations outside the page boundary (e.g. cannot draw a square outside of the page). Click save and return to the "View all submissions" page. Click the "View annotated PDF" button Verify that the submission is displayed with the saved annotations in a modal window that takes up the entire browser window. Verify that none of the annotations are displayed outside the page boundary. 
    • Affected Branches:
      MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.4 Branch:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-63171-master

      Description

      Prerequisites:

      • Have a Moodle with Ghostscript installed

      Steps to reproduce:

      • Login as teacher
      • Create an assignment in a course
      • Login as student
      • Go to the assignment in the course
      • Submit an assignment document which can be converted by Moodle (ideally a PDF file to keep Unoconv from joining the game)
      • Login as teacher
      • Grade the submitted assignment in the Edit PDF view
        • Add some stamps to the document, ideally near the documents edges
        • Add some comments to the document, ideally near the documents edges
        • Add some geometrical annotations (rectangles etc.) to the document, ideally near the documents edges
        • Finish grading
      • Login as student again
      • View the assignment again
      • Open the student's view with the "Open annotated PDF..." link
      • Scroll the document from left to right and from top to bottom

      Expected result:

      • The document and all of its annotations should be hidden as it leaves the viewport

      Actual result:

      • The document is hidden as it leaves the viewport
      • The geometrical annotations (rectangles etc.) are hidden as they leave the viewport
      • The stamps are not hidden as they leave the viewport
      • The comments are not hidden as they leave the viewport

      Additional information:
      I was able to reproduce this bug on Moodle 3.5, but I was not able to reproduce it directly on Moodle 3.4. Thus I label this issue preemptively with "regression" because it might be a regression of something in 3.5.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: