Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63179

Wrong localized string in self enrolment plugin

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.5.1, 3.6
    • Fix Version/s: 3.5.2
    • Component/s: Enrolments
    • Labels:
    • Testing Instructions:
      Hide
      1. Test in Boost
      2. Create a course, make sure self enrolment is activated
      3. As teacher, enrol a user manually
      4. Login as a different user, self enrol in that course
      5. As admin, go to Site adminstration → Language → Language customisation
      6. Choose english
      7. Open language pack for editing, continue.
      8. Look for Show strings of these components 'enrol_self.php', string identifier 'deleteselectedusers', click the "show strings" button
      9. Modify that string to "Delete selected enrol_self user enrolments", save changes to the language pack.
      10. Go to the courses "Participants" page
      11. Under the "With selected users..." pulldown menu, cross check the submenu item for "Self enrolment" says "Delete selected enrol_self user enrolments".
      Show
      Test in Boost Create a course, make sure self enrolment is activated As teacher, enrol a user manually Login as a different user, self enrol in that course As admin, go to Site adminstration → Language → Language customisation Choose english Open language pack for editing, continue. Look for Show strings of these components 'enrol_self.php', string identifier 'deleteselectedusers', click the "show strings" button Modify that string to "Delete selected enrol_self user enrolments", save changes to the language pack. Go to the courses "Participants" page Under the "With selected users..." pulldown menu, cross check the submenu item for "Self enrolment" says "Delete selected enrol_self user enrolments".
    • Affected Branches:
      MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:
    • Pull Master Branch:
      MDL-63179-master

      Description

      There is a mention of the localized string 'deleteselectedusers' from 'enrol_manual' in enrol/self/classes/deleteselectedusers_operation.php.
      enrol_manual should probably be replaced by enrol_self.
      http://git.moodle.org/gw?p=moodle.git;a=blob;f=enrol/self/classes/deleteselectedusers_operation.php;h=81f02482b61159b27dcfd651c21f2dc9b2c88274;hb=HEAD#l52

      Also, the @return tag of the function get_form() in the same file is wrong. enrol_manual_editselectedusers_form should be replaced with enrol_self_deleteselectedusers_form.
      http://git.moodle.org/gw?p=moodle.git;a=blob;f=enrol/self/classes/deleteselectedusers_operation.php;h=81f02482b61159b27dcfd651c21f2dc9b2c88274;hb=HEAD#l61

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 23 minutes
                  23m