[MDL-63179] Wrong localized string in self enrolment plugin - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.5.1, 3.6
Fix Version/s: 3.5.2
Component/s: Enrolments
Labels:
- ci
- patch
- triaged

Affected Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_35_STABLE
Pull from Repository:
https://github.com/lucaboesch/moodle
Pull Master Branch:
~~MDL-63179~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...lucaboesch:MDL-63179-master
Testing Instructions:
Hide

Test in Boost

Create a course, make sure self enrolment is activated

As teacher, enrol a user manually

Login as a different user, self enrol in that course

As admin, go to Site adminstration → Language → Language customisation

Choose english

Open language pack for editing, continue.

Look for Show strings of these components 'enrol_self.php', string identifier 'deleteselectedusers', click the "show strings" button

Modify that string to "Delete selected enrol_self user enrolments", save changes to the language pack.

Go to the courses "Participants" page

Under the "With selected users..." pulldown menu, cross check the submenu item for "Self enrolment" says "Delete selected enrol_self user enrolments".
Show
Test in Boost Create a course, make sure self enrolment is activated As teacher, enrol a user manually Login as a different user, self enrol in that course As admin, go to Site adminstration → Language → Language customisation Choose english Open language pack for editing, continue. Look for Show strings of these components 'enrol_self.php', string identifier 'deleteselectedusers', click the "show strings" button Modify that string to "Delete selected enrol_self user enrolments", save changes to the language pack. Go to the courses "Participants" page Under the "With selected users..." pulldown menu, cross check the submenu item for "Self enrolment" says "Delete selected enrol_self user enrolments".

Description

There is a mention of the localized string 'deleteselectedusers' from 'enrol_manual' in enrol/self/classes/deleteselectedusers_operation.php.
enrol_manual should probably be replaced by enrol_self.
http://git.moodle.org/gw?p=moodle.git;a=blob;f=enrol/self/classes/deleteselectedusers_operation.php;h=81f02482b61159b27dcfd651c21f2dc9b2c88274;hb=HEAD#l52

Also, the @return tag of the function get_form() in the same file is wrong. enrol_manual_editselectedusers_form should be replaced with enrol_self_deleteselectedusers_form.
http://git.moodle.org/gw?p=moodle.git;a=blob;f=enrol/self/classes/deleteselectedusers_operation.php;h=81f02482b61159b27dcfd651c21f2dc9b2c88274;hb=HEAD#l61

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2018-08-29-08-33-17-959.png
124 kB
29/Aug/18 4:33 PM

Issue Links

Discovered while testing

MDL-60811 Add delete bulk action to participants page for self-registered enrolments

Closed

Activity

People

Assignee:: Luca Bösch

Reporter:: Heiko Schach

Peer reviewer:: Amaia Anabitarte

Integrator:: David Monllaó

Tester:: Janelle Barcega

Participants:: Amaia Anabitarte, CiBoT, David Monllaó, David Mudrák (@mudrd8mz), Eloy Lafuente (stronk7), Heiko Schach, Janelle Barcega, Luca Bösch

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 18/Aug/18 3:40 AM

Updated:: 31/Aug/18 2:27 PM

Resolved:: 31/Aug/18 2:27 PM

Fix Release Date:: 10/Sep/18

Time Tracking

Estimated:

Remaining:

Logged:

23m