Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63202

Review XMLDB/DB specs of moodle xxxformat fields

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.6
    • Fix Version/s: None
    • Component/s: Database SQL/XMLDB, General
    • Labels:
      None
    • Affected Branches:
      MOODLE_36_STABLE

      Description

      Was looking to MDL-62660 when I detected that the tool_dataprivacy had a couple of descriptionformat database fields defined like int(1). Ideally they should be at very least 2.

      That made me look in general, using the command below:

      find . -name install.xml | xargs ag 'format".* LENGTH="1"'

      And I got:

      LENGTH="1" => 9 occurrences.
      LENGTH="2" => 65 occurrences.
      LENGTH="3" => 17 occurrences.
      LENGTH="4" => 37 occurrences.
      LENGTH="5" => 0 occurrences.
      LENGTH="6" => 0 occurrences.
      LENGTH="7" => 0 occurrences.
      LENGTH="8" => 0 occurrences.
      LENGTH="9" => 0 occurrences.
      

      This issue is about to:

      1) Try to normalize all them to LENGTH="2" (most used)
      2) Update all places in docs or template plugins where other LENGTH is specified.
      3) Try to check for this continuously (MDLSITE).

      Note that, really, we only have a hand of formats defined (0-4) (lib/weblib.php). So nothing is failing. In fact, surely changing the LENGTH="1" ones to the correct LENGTH="2" will enable up to 99 formats. Enough for sure.

      Just it's about normalizing the formats everywhere. And start verifying it. Up to you to decide how strict we want to go.

      Ciao

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                stronk7 Eloy Lafuente (stronk7)
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta, Jake Dallimore, Jun Pataleta
              • Votes:
                1 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: