Details
-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
3.6
-
None
-
MOODLE_36_STABLE
Description
Was looking to MDL-62660 when I detected that the tool_dataprivacy had a couple of descriptionformat database fields defined like int(1). Ideally they should be at very least 2.
That made me look in general, using the command below:
find . -name install.xml | xargs ag 'format".* LENGTH="1"'
|
And I got:
LENGTH="1" => 9 occurrences.
|
LENGTH="2" => 65 occurrences.
|
LENGTH="3" => 17 occurrences.
|
LENGTH="4" => 37 occurrences.
|
LENGTH="5" => 0 occurrences.
|
LENGTH="6" => 0 occurrences.
|
LENGTH="7" => 0 occurrences.
|
LENGTH="8" => 0 occurrences.
|
LENGTH="9" => 0 occurrences.
|
This issue is about to:
1) Try to normalize all them to LENGTH="2" (most used)
2) Update all places in docs or template plugins where other LENGTH is specified.
3) Try to check for this continuously (MDLSITE).
Note that, really, we only have a hand of formats defined (0-4) (lib/weblib.php). So nothing is failing. In fact, surely changing the LENGTH="1" ones to the correct LENGTH="2" will enable up to 99 formats. Enough for sure.
Just it's about normalizing the formats everywhere. And start verifying it. Up to you to decide how strict we want to go.
Ciao
Attachments
Issue Links
- Discovered while testing
-
MDL-62660 Data export download links don't expire
-
- Closed
-