Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63238

Regression: removal of card classes impacts background color

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 3.6
    • Fix Version/s: 3.6
    • Component/s: Themes
    • Testing Instructions:
      Hide
      1. Login as admin
      2. Navigate to Site Administration -> Appearance -> Boost
      3. Upload any background image in the Boost general settings form
      4. Save changes
      5. Navigate back to the Site Administration page
      6. Verify the Site Administration container box has a solid white background.
      Show
      Login as admin Navigate to Site Administration -> Appearance -> Boost Upload any background image in the Boost general settings form Save changes Navigate back to the Site Administration page Verify the Site Administration container box has a solid white background.
    • Affected Branches:
      MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_36_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-63238-master
    • Pull Master Diff URL:

      Description

      Regression due to MDL-63028. To replicate:

      1. Add the following css to the "Raw initial SCSS" section under advanced settings in the Boost theme settings: 

        body {
        		 
            background-image: url("https://hq.moodle.com/pluginfile.php/1/theme_more/backgroundimage/1480391664/Orange-highlights.jpg");
        		 
            background-size: cover;
        		 
            background-repeat: repeat;
        		 
        }

      2. Save changes, purge caches and visit a course home page. Notice the background of #region-main inherits the image, and is no longer #fff.

        Attachments

          Issue Links

          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-63028 Use flexbox for positioning the Boost footer

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              basbrands Bas Brands
              Reporter:
              jaked Jake Dallimore
              Peer reviewer:
              Mihail Geshoski Mihail Geshoski
              Integrator:
              David Monllaó David Monllaó
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                3/Dec/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 10 minutes
                  10m