[MDL-63238] Regression: removal of card classes impacts background color - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_36_STABLE
Fixed Branches:
MOODLE_36_STABLE
Pull from Repository:
git://github.com/bmbrands/moodle.git
Pull Master Branch:
~~MDL-63238~~-master
Pull Master Diff URL:
https://github.com/bmbrands/moodle/compare/8df868e9e0...MDL-63238-master
Testing Instructions:
Hide

Login as admin

Navigate to Site Administration -> Appearance -> Boost

Upload any background image in the Boost general settings form

Save changes

Navigate back to the Site Administration page

Verify the Site Administration container box has a solid white background.
Show
Login as admin Navigate to Site Administration -> Appearance -> Boost Upload any background image in the Boost general settings form Save changes Navigate back to the Site Administration page Verify the Site Administration container box has a solid white background.

Regression due to ~~MDL-63028~~. To replicate:

Add the following css to the "Raw initial SCSS" section under advanced settings in the Boost theme settings:

body {

    background-image: url("https://hq.moodle.com/pluginfile.php/1/theme_more/backgroundimage/1480391664/Orange-highlights.jpg");

    background-size: cover;

    background-repeat: repeat;

Save changes, purge caches and visit a course home page. Notice the background of #region-main inherits the image, and is no longer #fff.

is a regression caused by

MDL-63028 Use flexbox for positioning the Boost footer

Participants:: Bas Brands, CiBoT, Damyon Wiese, David Monllaó, Eloy Lafuente (stronk7), Gladys Basiana, Jake Dallimore, Martin Dougiamas, Mihail Geshoski

Estimated:

Remaining:

Logged:

10m