Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63263

Recycle bin should always include user data

    XMLWordPrintable

Details

    • MOODLE_33_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_35_STABLE, MOODLE_36_STABLE
    • MDL-63263-Master
    • Hide

      TAKE1 (as editing teacher in some steps)

      1. Login to the site as Site Admin
      2. Go to Site Administration > Plugins > Admin tools > Recycle bin. Ensure that course recycle bin is enabled.
      3. Go to Site Administration > Courses > Backup > Automated Backup Setup. Make sure "Include Users" option is enabled (it should by default).
      4. Create a course
      5. Create a quiz (1 question is enough).
      6. As a student, attempt the quiz and submit your attempt.
      7. As an editing teacher, delete the quiz
      8. Run php admin/cli/cron.php so that the deleted item is displayed on course recycle bin
      9. As an editing teacher go to the course recycle bin and restore the deleted item
      10. View the restored quiz, and verify that the student's quiz attempt has been restored.

      TAKE2 (as admin in some steps)

      1. Repeat steps 4-10 above... but, in the steps where "editing teacher" is used (steps 7 & 9), execute them as admin.
      Show
      TAKE1 (as editing teacher in some steps) Login to the site as Site Admin Go to Site Administration > Plugins > Admin tools > Recycle bin. Ensure that course recycle bin is enabled. Go to Site Administration > Courses > Backup > Automated Backup Setup. Make sure "Include Users" option is enabled (it should by default). Create a course Create a quiz (1 question is enough). As a student, attempt the quiz and submit your attempt. As an editing teacher , delete the quiz Run php admin/cli/cron.php  so that the deleted item is displayed on course recycle bin As an editing teacher go to the course recycle bin and restore the deleted item View the restored quiz, and verify that the student's quiz attempt has been restored. TAKE2 (as admin in some steps) Repeat steps 4-10 above... but, in the steps where "editing teacher" is used (steps 7 & 9), execute them as admin.

    Description

      DESCRIPTION
      The recycle bin currently uses the General backup defaults. "Include users" is unchecked in the General backup defaults. An item is deleted from a course and goes to the course recycle bin. When restored, the user expects the course item to be restored along with any associated submissions/user data.

      STEPS TO REPLICATE
      1. Login to the site and go to Admin tools > Recycle bin. Ensure that course recycle bin is enabled.
      2. Go to the General Backup Defaults page, then uncheck "Include users" and save changes
      3. Create a quiz or assignment
      4. As a student, submit an assignment or a quiz submission
      5. As an admin or teacher, delete the quiz or assignment
      6. Run SITEURL/admin/cron.php to expedite the deleted item showing up in the Recycle Bin
      7. Access course recycle bin and restore the deleted item
      8. View item restored in course and notice that no submission exists.

      OBSERVED BEHAVIOR:
      Restored item does not have user data/submissions

      EXPECTED BEHAVIOR:
      Any restored item from the recycle bin should have user data/submissions

      Attachments

        Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-65218 Recycle bin is broken if backup_auto_storage is set to specified directory for automated backups (Regression of MDL-63263)

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          has a non-specific relationship to

          New Feature - A new Moodle feature which has yet to be developed. MDL-65228 Create a new backup::MODE_RECYCLEBIN

          • Minor - Minor loss of function where workaround is possible
          • Open
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-68981 Recycle bin does not include user data if "General restore defaults > Include users" is No

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Activity

            People

              Nguyen Nathan Nguyen
              brian.winstead Brian Winstead
              Damyon Wiese Damyon Wiese
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Janelle Barcega Janelle Barcega
              Votes:
              2 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/May/19

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 50 minutes
                  2h 50m