Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63267

Rubrics do not consider the fillings table (backport of MDL-62535)

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Important This test requires changing code.

      Test export of advanced grading information.

      Rubrics

      1. Setup a rubric in an assignment activity.
        1. Create a new assignment.
        2. Under "Grade" > "Grading method" set this to Rubric.
        3. Click the Define new grading form from scratch.
        4. Add some criteria and then click the "save rubric and make it ready".
      2. Log in as a teacher and mark a student. Add feedback to each criterion.
      3. Use the script and export the data for the marked student.
      4. Verify that the rubric data is exported. This is located under the submission attempt in the assignment folder.

      Marking guide

      1. Setup a marking guide in an assignment activity.
        1. Create a new assignment.
        2. Under "Grade" > "Grading method" set this to Marking guide.
        3. Click the Define new grading form from scratch.
        4. Add some criteria and then click the "save marking guide and make it ready".
      2. Log in as a teacher and mark a student. Add feedback to each criterion.
      3. Use the script and export the data for the marked student.
      4. Verify that the marking guide data is exported. This is located under the submission attempt in the assignment folder.

      Test deprecated plugin display in the plugin privacy registry.

      1. Download 0001-MDL-62535-privacy-Deprecated-sample-commit.patch
      2. Open a terminal and go to your Moodle instance's root folder.
      3. Apply the test patch to your moodle instance:

        git am /path/to/0001-MDL-62535-privacy-Deprecated-sample-commit.patch
        

      4. On your browser, go to Site administration > Users > Privacy and policies > Plugin privacy registry.
      5. Confirm that there is a description about deprecated plugins in the top section.
      6. Confirm that expanding the "Advanced grading method" section shows Rubric to be deprecated.
      After the test
      1. Make sure to remove the test patch using "git reset --hard origin/YOUR_MOODLE_BRANCH".
        e.g. for master

        git reset --hard origin/MOODLE_35_STABLE // switch MOODLE_35_STABLE for the branch you are testing.
        

      Show
      Important This test requires changing code. Test export of advanced grading information. Rubrics Setup a rubric in an assignment activity. Create a new assignment. Under "Grade" > "Grading method" set this to Rubric. Click the Define new grading form from scratch. Add some criteria and then click the "save rubric and make it ready". Log in as a teacher and mark a student. Add feedback to each criterion. Use the script and export the data for the marked student. Verify that the rubric data is exported. This is located under the submission attempt in the assignment folder. Marking guide Setup a marking guide in an assignment activity. Create a new assignment. Under "Grade" > "Grading method" set this to Marking guide. Click the Define new grading form from scratch. Add some criteria and then click the "save marking guide and make it ready". Log in as a teacher and mark a student. Add feedback to each criterion. Use the script and export the data for the marked student. Verify that the marking guide data is exported. This is located under the submission attempt in the assignment folder. Test deprecated plugin display in the plugin privacy registry. Download 0001-MDL-62535-privacy-Deprecated-sample-commit.patch Open a terminal and go to your Moodle instance's root folder. Apply the test patch to your moodle instance: git am /path/to/0001-MDL-62535-privacy-Deprecated-sample-commit.patch On your browser, go to Site administration > Users > Privacy and policies > Plugin privacy registry. Confirm that there is a description about deprecated plugins in the top section. Confirm that expanding the "Advanced grading method" section shows Rubric to be deprecated. After the test Make sure to remove the test patch using " git reset --hard origin/YOUR_MOODLE_BRANCH ". e.g. for master git reset --hard origin/MOODLE_35_STABLE // switch MOODLE_35_STABLE for the branch you are testing.
    • Affected Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Fixed Branches:
      MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull 3.5 Branch:

      Description

      This is a backport of MDL-62535 to the 33, 34 and 35 branches.

      Originally considered a bug, but including API changes, it was only integrated to 3.6dev. But it seems that we may need this in stables as far as it's a real bug preventing some privacy information being correctly handled.

      So, to decide and apply if needed. ASAP.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/18

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours
                  2h