-
Bug
-
Resolution: Fixed
-
Minor
-
3.5.1, 3.6.5, 3.7.1, 3.8
-
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
-
MOODLE_36_STABLE, MOODLE_37_STABLE
-
MDL-63315-master -
-
We are seeing an issue where we are getting page failures and DB errors on our Postgres setup.
The PHP Log:
[06-Sep-2018 13:21:30 America/Detroit] Default exception handler: Error reading from database Debug: ERROR: cursor "crs5" already exists
|
SELECT cc.id, COUNT(c.id) AS coursecount
|
FROM mdl_course_categories cc
|
LEFT JOIN mdl_course c ON c.category = cc.id
|
WHERE cc.id IN ($1,$2)
|
GROUP BY cc.id
|
[array (
|
0 => '179',
|
1 => '299',
|
)]
|
Error code: dmlreadexception
|
* line 486 of /lib/dml/moodle_database.php: dml_read_exception thrown
|
* line 248 of /lib/dml/pgsql_native_moodle_database.php: call to moodle_database->query_end()
|
* line 764 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->query_end()
|
* line 1560 of /lib/navigationlib.php: call to pgsql_native_moodle_database->get_recordset_sql()
|
* line 1840 of /lib/navigationlib.php: call to global_navigation->load_all_courses()
|
* line 2588 of /lib/navigationlib.php: call to global_navigation->load_all_categories()
|
* line 1278 of /lib/navigationlib.php: call to global_navigation->add_course()
|
* line 224 of /blocks/navigation/block_navigation.php: call to global_navigation->initialise()
|
* line 166 of /blocks/navigation/block_navigation.php: call to block_navigation->get_navigation()
|
* line 288 of /blocks/moodleblock.class.php: call to block_navigation->get_content()
|
* line 230 of /blocks/moodleblock.class.php: call to block_base->formatted_contents()
|
* line 1211 of /lib/blocklib.php: call to block_base->get_content_for_output()
|
* line 1263 of /lib/blocklib.php: call to block_manager->create_block_contents()
|
* line 604 of /lib/outputrenderers.php: call to block_manager->ensure_content_created()
|
* line 39 of /theme/bootstrapbase/renderers/core_renderer.php: call to core_renderer->standard_head_html()
|
* line 36 of /theme/ou_bs_base/layout/columns2.php: call to theme_bootstrapbase_core_renderer->standard_head_html()
|
* line 1287 of /lib/outputrenderers.php: call to include()
|
* line 1217 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()
|
* line 1881 of /lib/setuplib.php: call to core_renderer->header()
|
* line 48 of /question/edit.php: call to bootstrap_renderer->__call()
|
And the Postgres Log:
2018-09-06 13:21:30.365 EDT [45862] ERROR: cursor "crs5" already exists
|
2018-09-06 13:21:30.365 EDT [45862] STATEMENT: DECLARE crs5 NO SCROLL CURSOR WITH HOLD FOR SELECT cc.id, COUNT(c.id) AS coursecount
|
FROM mdl_course_categories cc
|
LEFT JOIN mdl_course c ON c.category = cc.id
|
WHERE cc.id IN ($1,$2)
|
GROUP BY cc.id
|
Note that we do have dbpersist on, which may be causing this problem to show up, but that is a valid option, and we need it for performance reasons.
What I think it happening is that there is code somewhere in our system that opens a recordset but doesn't close it (either because of bad code or an exception is thrown).
Now in our particular case, it is always crs5, so I'm guessing we have code somewhat that is failing to close the 6th cursor opened for some reason, and I will work to track that down.
But, I think the broader problem is still there. IMO, Moodle should be making sure that the cursor is closed, or checking if it exists.
Personally, I think we should be adding recordset close to the shutdown handler just like we do for locks.
