[MDL-63321] Fix warning in Calendar month block after MDL-60587 - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.4.5, 3.5.1, 3.6
Fix Version/s: 3.4.6, 3.5.3
Component/s: Blocks
Labels:
- blackboard
- ci
- netspot

Database:

Any
Affected Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Pull from Repository:
https://github.com/tlock/moodle.git
Pull Master Branch:
mdl63321-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...tlock:mdl63321-master
Difficulty:
Easy
Testing Instructions:
Hide

Note: Better test on Clean theme since the warning message gets covered by the nav header in Boost.

Add the Calendar block as a site block showing on all pages.

In Site Admin, click Courses then "Manage courses and categories"

Confirm that you don't see a PHP Notice warning.
Show
Note: Better test on Clean theme since the warning message gets covered by the nav header in Boost. Add the Calendar block as a site block showing on all pages. In Site Admin, click Courses then "Manage courses and categories" Confirm that you don't see a PHP Notice warning.

Description

After ~~MDL-60587~~ has been integrated, the category contextlevel is determined to true when managing courses but the categoryid isn't set so the warning is thrown.

This item fixes the warning check for category id.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

image-2018-09-12-16-11-56-033.png
128 kB
12/Sep/18 4:11 PM

Issue Links

is a regression caused by

MDL-60587 Inconsistent calendar information shown across different views

Closed

Activity

People

Assignee:: Tim Lock

Reporter:: Tim Lock

Peer reviewer:: Luca Bösch

Integrator:: Jun Pataleta

Tester:: Janelle Barcega

Participants:: CiBoT, Eloy Lafuente (stronk7), Janelle Barcega, Jun Pataleta, Luca Bösch, Tim Lock

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 07/Sep/18 12:15 PM

Updated:: 14/Sep/18 5:50 PM

Resolved:: 14/Sep/18 5:50 PM

Fix Release Date:: 12/Nov/18

Time Tracking

Estimated:

Remaining:

Logged:

14m