[MDL-63323] Wrong use of "classes" attribute to action_link in activity_navigation class - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.4.6, 3.5.3, 3.6
Fix Version/s: 3.4.6, 3.5.3
Component/s: Course, Navigation
Labels:
- ci
- patch

Testing Instructions:

Hide

Setup:
1. Go to a course
2. Create two or more resources

Testing scenario
1. Go into a resource page
2. Use the browser inspector to check the HTML on the left bottom link to prev activity.
3. The class attribute should be: class="btn btn-link"

Show
Setup: 1. Go to a course 2. Create two or more resources Testing scenario 1. Go into a resource page 2. Use the browser inspector to check the HTML on the left bottom link to prev activity. 3. The class attribute should be: class="btn btn-link"
Difficulty:
Easy
Affected Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
Fixed Branches:
MOODLE_34_STABLE, MOODLE_35_STABLE
Pull from Repository:
https://github.com/davidherney/moodle
Pull 3.5 Branch:
~~MDL-63323~~-35-wrong-classes-attribute-into-activity_navigation
Pull 3.5 Diff URL:
https://github.com/davidherney/moodle/commit/9b40d154ffff237119b6203c21abb0e354547772
Pull Master Branch:
~~MDL-63323~~-wrong-classes-attribute-into-activity_navigation
Pull Master Diff URL:
https://github.com/davidherney/moodle/commit/97fd2fb575b396710c107a183391034c34cd34ce

Description

For the activity_navigation class.
Into the attributes list for the action_link, the CSS class value is set into the "classes" key. However, the action_link class require it value in "class" key.

In the method action_link->export_for_template exists the nex line:

$data->classes = isset($attributes['class']) ? $attributes['class'] : '';

The "class" key is checked and it is assigned to "classes" attribute.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

image-2018-10-10-08-13-43-349.png
14 kB
10/Oct/18 8:13 AM

Issue Links

caused a regression

MDL-64550 Boost Theme - Navigation overlaps combo box

Closed

is duplicated by

MDL-63355 Class issue - footer pagination

Closed

Activity

People

Assignee:

David Herney Bernal

Reporter:

David Herney Bernal

Peer reviewer:

Daniel Neis Araujo

Integrator:

David Monllaó

Tester:

Janelle Barcega

Participants:

CiBoT, Daniel Neis Araujo, David Herney Bernal, David Monllaó, Janelle Barcega

Component watchers:

Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias

Votes:

0 Vote for this issue

Watchers:

3 Start watching this issue

Dates

Created:

07/Sep/18 1:51 PM

Updated:

11/Apr/19 5:56 PM

Resolved:

11/Oct/18 10:09 PM

Fix Release Date:

12/Nov/18

Time Tracking

Estimated:

Remaining:

Logged:

10m