Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63323

Wrong use of "classes" attribute to action_link in activity_navigation class

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.4.6, 3.5.3, 3.6
    • 3.4.6, 3.5.3
    • Course, Navigation
    • MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • MOODLE_34_STABLE, MOODLE_35_STABLE
    • MDL-63323-wrong-classes-attribute-into-activity_navigation
    • Easy
    • Hide

      Setup:
      1. Go to a course
      2. Create two or more resources

      Testing scenario
      1. Go into a resource page
      2. Use the browser inspector to check the HTML on the left bottom link to prev activity.
      3. The class attribute should be: class="btn btn-link"

      Show
      Setup: 1. Go to a course 2. Create two or more resources Testing scenario 1. Go into a resource page 2. Use the browser inspector to check the HTML on the left bottom link to prev activity. 3. The class attribute should be: class="btn btn-link"

    Description

      For the activity_navigation class.
      Into the attributes list for the action_link, the CSS class value is set into the "classes" key. However, the action_link class require it value in "class" key.

      In the method action_link->export_for_template exists the nex line:

      $data->classes = isset($attributes['class']) ? $attributes['class'] : '';

      The "class" key is checked and it is assigned to "classes" attribute.

      Attachments

        Issue Links

          Activity

            People

              cirano David Herney Bernal
              cirano David Herney Bernal
              Daniel Neis Araujo Daniel Neis Araujo
              David Monllaó David Monllaó
              Janelle Barcega Janelle Barcega
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona), Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Nov/18

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 10 minutes
                  10m