Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63323

Wrong use of "classes" attribute to action_link in activity_navigation class

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.4.6, 3.5.3, 3.6
    • Fix Version/s: 3.4.6, 3.5.3
    • Component/s: Course, Navigation
    • Labels:
    • Testing Instructions:
      Hide

      Setup:
      1. Go to a course
      2. Create two or more resources

      Testing scenario
      1. Go into a resource page
      2. Use the browser inspector to check the HTML on the left bottom link to prev activity.
      3. The class attribute should be: class="btn btn-link"

      Show
      Setup: 1. Go to a course 2. Create two or more resources Testing scenario 1. Go into a resource page 2. Use the browser inspector to check the HTML on the left bottom link to prev activity. 3. The class attribute should be: class="btn btn-link"
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • Fixed Branches:
      MOODLE_34_STABLE, MOODLE_35_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-63323-wrong-classes-attribute-into-activity_navigation
    • Pull Master Diff URL:

      Description

      For the activity_navigation class.
      Into the attributes list for the action_link, the CSS class value is set into the "classes" key. However, the action_link class require it value in "class" key.

      In the method action_link->export_for_template exists the nex line:

      $data->classes = isset($attributes['class']) ? $attributes['class'] : '';

      The "class" key is checked and it is assigned to "classes" attribute.

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-64550 Boost Theme - Navigation overlaps combo box

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-63355 Class issue -  footer pagination

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              cirano David Herney Bernal
              Reporter:
              cirano David Herney Bernal
              Peer reviewer:
              Daniel Neis Araujo Daniel Neis Araujo
              Integrator:
              David Monllaó David Monllaó
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Nov/18

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 10 minutes
                  10m