Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63323

Wrong use of "classes" attribute to action_link in activity_navigation class

XMLWordPrintable

    • MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
    • MOODLE_34_STABLE, MOODLE_35_STABLE
    • MDL-63323-wrong-classes-attribute-into-activity_navigation
    • Easy
    • Hide

      Setup:
      1. Go to a course
      2. Create two or more resources

      Testing scenario
      1. Go into a resource page
      2. Use the browser inspector to check the HTML on the left bottom link to prev activity.
      3. The class attribute should be: class="btn btn-link"

      Show
      Setup: 1. Go to a course 2. Create two or more resources Testing scenario 1. Go into a resource page 2. Use the browser inspector to check the HTML on the left bottom link to prev activity. 3. The class attribute should be: class="btn btn-link"

      For the activity_navigation class.
      Into the attributes list for the action_link, the CSS class value is set into the "classes" key. However, the action_link class require it value in "class" key.

      In the method action_link->export_for_template exists the nex line:

      $data->classes = isset($attributes['class']) ? $attributes['class'] : '';

      The "class" key is checked and it is assigned to "classes" attribute.

            cirano David Herney Bernal
            cirano David Herney Bernal
            Daniel Neis Araujo Daniel Neis Araujo
            David Monllaó David Monllaó
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 10 minutes
                10m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.